Skip to content

Remove pickle from dist ckpt#3368

Draft
Phlip79 wants to merge 1 commit intoNVIDIA:mainfrom
Phlip79:philip/remove-pickle-from-ckpt
Draft

Remove pickle from dist ckpt#3368
Phlip79 wants to merge 1 commit intoNVIDIA:mainfrom
Phlip79:philip/remove-pickle-from-ckpt

Conversation

@Phlip79
Copy link
Copy Markdown
Member

@Phlip79 Phlip79 commented Feb 11, 2026

What does this PR do ?

Removing pickle from the repo. More context: https://gitlab-master.nvidia.com/ADLR/megatron-lm/-/issues/536. Tracking in #3324.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Phlip79 Phlip79 requested review from a team as code owners February 11, 2026 18:09
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Feb 11, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Phlip79
Copy link
Copy Markdown
Member Author

Phlip79 commented Feb 11, 2026

/ok to test 17c0c6f

@ko3n1g ko3n1g requested a review from a team February 11, 2026 18:09
@ko3n1g ko3n1g added this to the Core 0.16 milestone Feb 11, 2026
@Phlip79 Phlip79 added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. complexity: low labels Feb 11, 2026
@sbak5
Copy link
Copy Markdown
Contributor

sbak5 commented Feb 11, 2026

torch.save is a pickle + appending it to zip archive. So, it doesn't avoid pickle.
https://github.com/pytorch/pytorch/blob/main/torch/serialization.py#L1184

@Phlip79 Phlip79 marked this pull request as draft February 12, 2026 06:52
@Phlip79
Copy link
Copy Markdown
Member Author

Phlip79 commented Feb 12, 2026

torch.save is a pickle + appending it to zip archive. So, it doesn't avoid pickle. https://github.com/pytorch/pytorch/blob/main/torch/serialization.py#L1184

Great point. Marking this PR as draft until this is resolved.

@Phlip79 Phlip79 removed the request for review from a team April 15, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants