Skip to content

Move OS model examples to separate sub-directory#3352

Draft
Phlip79 wants to merge 3 commits intoNVIDIA:mainfrom
Phlip79:philip/move-os-models
Draft

Move OS model examples to separate sub-directory#3352
Phlip79 wants to merge 3 commits intoNVIDIA:mainfrom
Phlip79:philip/move-os-models

Conversation

@Phlip79
Copy link
Copy Markdown
Member

@Phlip79 Phlip79 commented Feb 10, 2026

What does this PR do ?

As part of #3324, we are re-organizing the examples. This PR moves all OS model examples into a separate sub-directory called open_models.

Also, this PR gets rid of BERT and Mixtral examples. We recommend using Megatron-Bridge when using OS models.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Phlip79 Phlip79 requested review from a team as code owners February 10, 2026 21:12
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Feb 10, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g ko3n1g requested a review from a team February 10, 2026 21:12
@Phlip79 Phlip79 added Final Review PR is in the "final review" stage complexity: low labels Feb 10, 2026
@Phlip79
Copy link
Copy Markdown
Member Author

Phlip79 commented Feb 12, 2026

/ok to test 5b97101

@Phlip79
Copy link
Copy Markdown
Member Author

Phlip79 commented Feb 12, 2026

/ok to test 7c267be

@jaredcasper
Copy link
Copy Markdown
Contributor

If we support BERT we should have an example of how to run it. If we aren't going to support BERT, we should remove support for it.

What's the point of adding the "open_models" directory, why does it matter?

@Phlip79 Phlip79 added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. and removed Final Review PR is in the "final review" stage labels Mar 5, 2026
@Phlip79 Phlip79 removed the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Mar 30, 2026
@Phlip79 Phlip79 marked this pull request as draft March 30, 2026 23:49
@Phlip79 Phlip79 removed the request for review from a team April 15, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants