Skip to content

Added polyline interpolation (in the new lane_helpers sub-package)#29

Merged
xupinjie merged 1 commit into
NVIDIA:mainfrom
RmSchaffert:lane_helpers_polyline
Jun 26, 2026
Merged

Added polyline interpolation (in the new lane_helpers sub-package)#29
xupinjie merged 1 commit into
NVIDIA:mainfrom
RmSchaffert:lane_helpers_polyline

Conversation

@RmSchaffert

@RmSchaffert RmSchaffert commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Added a new lane_helpers package with polyline interpolation as the first contained functionality

Type of Change

Please select (at least one):

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation / examples / tutorials / demos
  • Supporting functionality change (fix or feature in documentation generation, helper scripts, ...)
  • Refactoring / internal change
  • Other (please describe):

Testing

Checklist for testing:

  • Tests added or updated if/as needed
  • Repository test runner executed: scripts/run_tests.sh

Optionally, add a brief description.

Documentation, Examples, Tutorials, Demos

Checklist for documentation:

  • User-facing documentation updated if/as needed (including API docs)
  • Examples / tutorials / demos updated or added (if relevant)
  • Limitations and constraints documented (if relevant)
  • Performance documented (if relevant)
  • Documentation building successful & checks outlined in the Documentation Checks section of the Contribution Guide are performed

Optionally, add a brief description.

Code Quality

Checklist for dependencies:

  • Dependencies updated in the relevant pyproject.toml if/as needed
  • Code formatted according to the Code Formatting Guide

Optionally, add a brief description.

Related Issues / Context

If applicable, link related issues, discussions etc.


DCO / Sign-Off

Please refer to the section on Signing Your Work & Developer Certificate of Origin (DCO)
in the Contribution Guide before submitting your contribution.

References

For additional details, please refer to the Contribution Guide.
The following guides are available (referenced in the Contribution Guide for further details):

Please also refer to the summary checklist in the Contribution Guide,
which is a guideline for what to consider when submitting your contribution and covers the same topics as the checklists above.

@RmSchaffert

Copy link
Copy Markdown
Collaborator Author

/build

@RmSchaffert RmSchaffert force-pushed the lane_helpers_polyline branch from f5f64ed to c78240b Compare June 10, 2026 07:54
@RmSchaffert

Copy link
Copy Markdown
Collaborator Author

/build

@RmSchaffert RmSchaffert force-pushed the lane_helpers_polyline branch from c78240b to b04b055 Compare June 11, 2026 03:09
@RmSchaffert

Copy link
Copy Markdown
Collaborator Author

/build

1 similar comment
@RmSchaffert

Copy link
Copy Markdown
Collaborator Author

/build

@RmSchaffert RmSchaffert marked this pull request as ready for review June 15, 2026 09:51
@RmSchaffert RmSchaffert requested a review from xupinjie June 16, 2026 02:00
Comment thread packages/lane_helpers/ext_impl/polyline/include/helper_macros.cuh Outdated
Comment thread packages/lane_helpers/ext_impl/polyline/include/helper_macros.cuh Outdated
Comment thread packages/lane_helpers/ext_impl/polyline/src/polyline.cpp Outdated
@RmSchaffert RmSchaffert mentioned this pull request Jun 23, 2026
16 tasks
- Added polyline interpolation
- Cleaned up error handlingh in torch extensions
- Added functionality to generate plots during docs generation

Signed-off-by: Roman Schaffert <rschaffert@nvidia.com>
@RmSchaffert RmSchaffert force-pushed the lane_helpers_polyline branch from b04b055 to e99dbff Compare June 24, 2026 03:29
@RmSchaffert

Copy link
Copy Markdown
Collaborator Author

Apart from the comments above, I also updated other contained packages (batching_helpers and draw_heatmap) to use the fixed CUDA & torch error handling.

I also added functionality to generate plots from committed data instead of committing the resulting images.

@xupinjie The plot generation is according to our discussion in PR #36. It is standardized and a package can provide a hook if it needs to generate plots (or other files) during docs build.

@RmSchaffert

Copy link
Copy Markdown
Collaborator Author

/build

@xupinjie xupinjie merged commit e186132 into NVIDIA:main Jun 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants