Repository navigation
Add doc for Newton-Schulz orthogonalization quality - #309
Conversation
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| if coefficient in {"simple", "aol", "cans"}: | ||
| continue |
There was a problem hiding this comment.
plot_results silently drops simple, aol, and cans, although --coefficients accepts and evaluates them. A valid run with --coefficients=simple --plot=... saves a plot with no curves. Plot every requested set, or make the filter explicit and reject selections that would produce an empty plot.
| if coefficient in {"simple", "aol", "cans"}: | |
| continue |
| ```bash | ||
| python -m benchmarks.newton_schulz_quality \ | ||
| --precisions=highest,high,medium \ | ||
| --steps=5,8,10,16 --spectra=gaussian,uniform,hilbert,logspace \ | ||
| --output=/tmp/newton-schulz-quality.json \ | ||
| --plot=/tmp/newton-schulz-quality.png |
There was a problem hiding this comment.
The command needs setup instructions. The script requires torch.linalg.polar and says PyTorch 2.14 or newer, defaults to CUDA, and imports matplotlib for the requested plot. The lockfile selects PyTorch 2.8.0, and no dependency group declares matplotlib.
Explain how to prepare the environment and record the PyTorch version and GPU used for the published figure. Readers need these details to rerun and compare the results.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
/ok to test 3b734f3 |
@skyw, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test 3b734f3 |
@skyw, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test 3b734f3 |
@skyw, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test 3b734f3 |
1 participant
No description provided.