Repository navigation
Change CI to two fixed seed runs - #305
Merged
Merged
Conversation
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test 4c2847d |
Contributor
|
Signed-off-by: Hao Wu <skyw@nvidia.com>
Contributor
Author
|
/ok to test b085453 |
mkhona-nvidia
approved these changes
Sep 29, 2026
skyw
enabled auto-merge (squash)
September 29, 2026 21:13
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been using two rounds of test in CI, one with fixed seed and one without. As we adding more complex tests, the error margin starts vary more with different seed. If we keep increasing threshold to allow maximum variance caused by random seed to pas, it can start gating real errors and defeat the purpose of having multiple rounds in CI.
The decision is to change to two rounds both with fixed seed. And more rounds can be added trivially by just adding more seed into the loop.