Repository navigation
Fix Polar Express Coefficient Iterator for >8 step polar express - #303
Merged
Merged
Conversation
Signed-off-by: mkhona <mkhona@nvidia.com>
Signed-off-by: mkhona <mkhona@nvidia.com>
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
skyw
requested changes
Sep 24, 2026
Signed-off-by: mkhona <mkhona@nvidia.com>
skyw
requested changes
Oct 12, 2026
Signed-off-by: mkhona <mkhona@nvidia.com>
skyw
previously approved these changes
Oct 12, 2026
skyw
left a comment
skyw
left a comment
Contributor
There was a problem hiding this comment.
This is a bit out of original design and doesn't look clean.
Any future change we should consider redesign the whole thing.
Contributor
|
@greptile |
mkhona-nvidia
changed the title
Signed-off-by: mkhona <mkhona@nvidia.com>
Signed-off-by: mkhona <mkhona@nvidia.com>
mkhona-nvidia
marked this pull request as ready for review
October 12, 2026 22:21
Contributor
Author
|
/ok to test 0c484d0 |
skyw
approved these changes
Oct 12, 2026
skyw
enabled auto-merge (squash)
October 12, 2026 22:26
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes for polar express NS