chore(agentic-ci): declare numpy as direct dep of data-designer-engine#676
Open
github-actions[bot] wants to merge 1 commit into
Open
chore(agentic-ci): declare numpy as direct dep of data-designer-engine#676github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…r-engine The engine package imports numpy directly (e.g. `from numpy.typing import NDArray` in `sampling_gen/constraints.py`) but only declared it transitively via `data-designer-config`. Add `numpy>=1.23.5,<3` to the engine's own `[project.dependencies]`, matching the specifier already used by the config package. No runtime behavior changes.
Contributor
Greptile SummaryDeclares
|
| Filename | Overview |
|---|---|
| packages/data-designer-engine/pyproject.toml | Adds numpy>=1.23.5,<3 as a direct dependency in alphabetical order, matching the version range already declared in data-designer-config. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[data-designer-engine] -->|direct dep| B[data-designer-config]
A -->|direct dep — NEW| C[numpy>=1.23.5,<3]
B -->|direct dep| C
A -->|direct dep| D[scipy>=1.11.0,<2]
D -->|requires| C
Reviews (1): Last reviewed commit: "chore(agentic-ci): declare numpy as dire..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declare
numpyas a direct dependency ofdata-designer-engine.Why
Per
AGENTS.mdand the dependencies-suite audit (2026-05-19): theengine imports
numpydirectly but onlydata-designer-configdeclared it. Engine relied on transitive resolution via the config
package, which works for the monorepo install but is fragile if
data-designer-engineis ever installed standalone, and it bypassesthe "each package declares what it directly imports" contract.
Direct imports detected:
packages/data-designer-engine/src/data_designer/engine/sampling_gen/constraints.py(
from numpy.typing import NDArrayat module import time, plusimport numpy as npunderTYPE_CHECKING)packages/data-designer-engine/src/data_designer/engine/sampling_gen/data_sources/base.py(TYPE_CHECKING-guarded
import numpy as npandfrom numpy.typing import NDArray)(Audit also flagged additional engine modules using
numpyvia thelazy-import system — those will be covered by their own findings if
present; this PR only adds the missing declaration.)
What changed
A single line —
"numpy>=1.23.5,<3",— added to the[tool.hatch.metadata.hooks.uv-dynamic-versioning].dependencieslistin
packages/data-designer-engine/pyproject.toml, in alphabeticalposition between
networkxandpython-multipart. The specifier iscopied verbatim from
packages/data-designer-config/pyproject.tomlwhere
numpy>=1.23.5,<3is already declared, so no version-rangereconciliation is required.
Tests
make install-devresolved the lockfile cleanly (only the engine'sown version metadata changed in
uv.lock).make test-engine— 2055 passed in 34.91s.Provenance
Generated by the agentic-ci
dependenciessuite (daily run,2026-05-19). Finding id
b10e09fc453c, fix confidence 0.85, severityhigh (heavy import bypassing the declared-deps contract).