docs: remove docs code reference#674
Conversation
|
MkDocs preview: https://49f2a817.dd-docs-preview.pages.dev Fern preview: https://nvidia-preview-pr-674.docs.buildwithfern.com/nemo/datadesigner
|
PR #674 Review —
|
Greptile SummaryThis PR removes the generated code-reference docs surface from both MkDocs and Fern, strips the generation tooling (
|
| Filename | Overview |
|---|---|
| fern/scripts/fern-published-branch.py | Replaces sync_code_reference_archive with remove_retired_reference_archive; adds remove_navigation_section helper using the same section-boundary logic as the existing extract/replace helpers. Logic is correct. |
| fern/versions/latest.yml | Removes the Code Reference section (70 lines) from the latest version nav; no remaining references to deleted pages. |
| fern/docs.yml | Removes the libraries config block and all code_reference redirects; also updates the comment referencing mkdocstrings. Clean removal. |
| mkdocs.yml | Removes Code Reference nav section, mkdocstrings plugin config, watch paths for source packages, and mkdocstrings.css from extra_css. Consistent cleanup. |
| Makefile | Removes generate-fern-api-reference targets, py2fern variables, and updates prepare-fern-docs to no longer depend on the removed targets. |
| pyproject.toml | Removes mkdocstrings-python, mkdocstrings, and py2fern from the docs dependency group. |
| .github/workflows/docs-preview.yml | Removes DOCS_PY2FERN env var from the check-fern-docs workflow step. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[sync_source called] --> B[Preserve archived versions to tmpdir]
B --> C[clear_published_tree]
C --> D[copytree source → published root]
D --> E[merge_preserved_versions\nrestore archived v*.yml + pages/]
E --> F[remove_retired_reference_archive]
F --> G[For each archived v*.yml\nremove_navigation_section\nCode Reference]
G --> H[glob versions_dir/*/pages/code_reference\nshutil.rmtree each]
H --> I[For each v*/pages dir\ncopy cleaned concept/plugin pages\nfrom latest source]
I --> J[materialize_version_nav_pages]
J --> K[restore_versions_block]
K --> L[validate_redirect_targets]
L --> M[write_publish_metadata]
Reviews (2): Last reviewed commit: "docs: address generated reference review" | Re-trigger Greptile
|
Thanks for putting this together, @andreatgretel! SummaryThis removes the MkDocs/Fern generated code reference surface, its generation plumbing, dependency entries, nav, redirects, and published-archive cleanup path. The implementation matches the PR description: source-tree sweeps are clean for the old paths/tools, and a dry-run of FindingsWarnings — Worth addressing
What Looks Good
VerdictNeeds changes: please remove or reword the remaining generated-reference breadcrumb in This review was generated by an AI assistant. |
|
thanks for the careful review! fixed that last breadcrumb by rewording it around guides, concepts, tutorials, and recipes. pushed in 20555a7. |
📋 Summary
Removes the generated code reference docs from both MkDocs and Fern so the docs no longer publish or link to the retired API reference surface. This also removes the generation plumbing and adds publish-branch cleanup for archived Fern versions so stale reference pages do not survive in docs-website archives.
🔗 Related Issue
N/A
🔄 Changes
🗑️ Removed
docs/code_reference/**pages, Fernfern/versions/latest/pages/code_reference/**pages, mkdocstrings CSS, and py2fern normalization script.🔧 Changed
fern/scripts/fern-published-branch.pyto strip retired reference archive nav/pages and refresh affected archived concept/plugin pages during publish sync.🔍 Attention Areas
fern/scripts/fern-published-branch.py- Archived Fern versions copy cleaned current versions of the affected concept/plugin pages during publish sync so stale reference links are removed from historical docs.🧪 Testing
.venv/bin/ruff check --fix ..venv/bin/ruff format .make check-fern-docspasses with 0 errors and 2 existing warnings.venv/bin/mkdocs buildpasses with existing docs warningsgit diff --checkmake check-fern-docsmake testpasses (N/A - docs-only; not run)✅ Checklist