Add pre-commit for better linting

.github/workflows/debian-packages.yml

@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -318,4 +318,4 @@ jobs:
         sleep 2
         kill -9 $(cat /tmp/gwm.pid) 2>/dev/null || true
         ros2 daemon stop || true
-      shell: bash
+      shell: bash

.github/workflows/ros-tests.yml

@@ -1,5 +1,5 @@
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -27,6 +27,17 @@ env:
   ROS_AUTOMATIC_DISCOVERY_RANGE: LOCALHOST
 
 jobs:
+  pre-commit:
+    name: Pre-commit checks (linting, copyright check, etc.)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Install dependencies
+        run: sudo apt-get update && sudo apt-get install -y uncrustify git
+      - uses: pre-commit/action@v3.0.1
+
   test:
     name: Test ROS2 ${{ matrix.ros_distro }}
     runs-on: ubuntu-latest
@@ -138,4 +149,4 @@ jobs:
       with:
         name: test-results-${{ matrix.ros_distro }}
         path: build/*/test_results/**/*.xml
-        retention-days: 7
+        retention-days: 7

.gitignore

@@ -89,4 +89,4 @@ _deps
 
 # Temporary files
 *.tmp
-*.temp
+*.temp

.pre-commit-config.yaml

@@ -0,0 +1,58 @@
+# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-License-Identifier: Apache-2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+exclude: ^(build|install)/
+repos:
+- repo: https://github.com/pre-commit/pre-commit-hooks
+  rev: v6.0.0
+  hooks:
+    - id: check-yaml
+    - id: end-of-file-fixer
+    - id: trailing-whitespace
+- repo: https://github.com/hhatto/autopep8
+  rev: v2.3.1
+  hooks:
+    - id: autopep8
+      args: [--max-line-length=99, -i]
+- repo: https://github.com/pycqa/flake8
+  rev: 7.1.1
+  hooks:
+    - id: flake8
+      args: [--max-line-length=99, '--extend-ignore=B902,C816,D100,D101,D102,D103,D104,D105,D106,D107,D203,D212,D404,I202']
+- repo: https://github.com/scop/pre-commit-shfmt
+  rev: v3.12.0-2
+  hooks:
+    - id: shfmt
+- repo: https://github.com/sbrunner/hooks
+  rev: 1.6.1
+  hooks:
+    - id: copyright-required
+      exclude: '(^\.git/|(\.ini|\.json|\.service|__init__\.py|\.md|\.gitkeep|\.conf|LICENSE|\.toml|\.template|\.style\..*|\.gitattributes|\.gitignore|\.editorconfig|\.bash-completion|\.install|\.links|changelog|debian/source/format|.codespellrc|copyright|ament_code_style\.cfg|test_pep257\.py|test_flake8\.py|test_copyright\.py)$)'
+- repo: local
+  hooks:
+    - id: uncrustify
+      name: uncrustify
+      entry: uncrustify -c ament_code_style.cfg --replace --no-backup
+      language: system
+      types_or: [c, c++]
+    - id: signed-off-by
+      name: check commit is signed off
+      entry: "bash -c 'grep -q \"^Signed-off-by: \" \"$1\"' --"
+      language: system
+      stages: [commit-msg]
+      pass_filenames: true
+- repo: https://github.com/codespell-project/codespell
+  rev: v2.4.1
+  hooks:
+    - id: codespell

Contributing.md

@@ -1,4 +1,8 @@
-We welcome PRs for new features or bugfixes, CI will automatically run automated tests on new PRs. You can also use the scripts/docker-test.sh to debug tests for a particular distribution locally. 
+# Contributing
+
+We welcome PRs for new features or bugfixes, CI will automatically run automated tests on new PRs. You can also use the scripts/docker-test.sh to debug tests for a particular distribution locally.
+
+## Sign Off
 
 We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
 
@@ -52,3 +56,22 @@ By making a contribution to this project, I certify that:
     maintained indefinitely and may be redistributed consistent with
     this project or the open source license(s) involved.
 ```
+
+## Pre-commit hooks (linting, sign-off check, copyright check, etc.)
+
+If you would like the linter and other checks to run on every commit use [pre-commit](https://pre-commit.com/):
+
+```
+sudo apt install uncrustify pipx
+pipx install pre-commit
+pre-commit install --hook-type pre-commit --hook-type commit-msg
+pre-commit run --all-files  # try it out, this will run every commit now
+```
+
+On every commit now a series of checks will be run to ensure the changes are meeting this repositories requirements.
+
+Uninstall pre-commit with:
+
+```
+pre-commit uninstall --hook-type pre-commit --hook-type commit-msg
+```

README.md

@@ -109,4 +109,4 @@ If you want to use it as a command line tool, you can do so with the following l
 
 ```bash
 ros2 launch greenwave_monitor hz.launch.py gw_monitored_topics:='["/topic1", "/topic2"]'
-```
+```

greenwave_monitor/CMakeLists.txt

@@ -1,4 +1,4 @@
-# Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

greenwave_monitor/examples/README.md

@@ -31,4 +31,4 @@ Node(
 ),
 ```
 
-To see the output with the r2s_gw dashboard, run `ros2 run r2s_gw r2s_gw` in a separate terminal.
+To see the output with the r2s_gw dashboard, run `ros2 run r2s_gw r2s_gw` in a separate terminal.

greenwave_monitor/greenwave_monitor/ncurses_frontend.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python3
 
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

greenwave_monitor/greenwave_monitor/test_utils.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python3
 
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -176,7 +176,7 @@ def find_best_diagnostic(
         diagnostics: List[DiagnosticStatus],
         expected_frequency: float,
         message_type: str
-        ) -> Tuple[Optional[DiagnosticStatus], Optional[Tuple[float, float, float]]]:
+) -> Tuple[Optional[DiagnosticStatus], Optional[Tuple[float, float, float]]]:
     """Find the diagnostic message with frequency closest to expected."""
     best_status = None
     best_values = None

greenwave_monitor/greenwave_monitor/ui_adaptor.py

@@ -1,7 +1,7 @@
 #!/usr/bin/env python3
 
 # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-# Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

greenwave_monitor/include/greenwave_diagnostics.hpp

@@ -1,5 +1,5 @@
 // SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-// Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+// Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

greenwave_monitor/include/greenwave_monitor.hpp

@@ -1,5 +1,5 @@
 // SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-// Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+// Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

greenwave_monitor/include/minimal_publisher_node.hpp

@@ -1,5 +1,5 @@
 // SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES
-// Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+// Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

greenwave_monitor/launch/hz.launch.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

greenwave_monitor/launch/test_publishers.launch.py

@@ -1,4 +1,4 @@
-# Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.