Consolidate more benchmark code, make ff optimize more robust - #242
Merged
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| benchmarks/bench_utils/loaders.py | Adds an opt-in 10% candidate reserve while preserving existing loader bounds and sampling behavior by default. |
| benchmarks/bench_utils/molprep.py | Adds a safe Linux-compatible CPU availability helper with fallbacks across supported Python versions. |
| benchmarks/ff_optimize_bench.py | Buffers and filters force-field inputs and adds a dedicated conformer process setting, but its automatic default uses every available CPU rather than the repository's half-CPU convention. |
| benchmarks/tests/test_loaders.py | Covers minimum buffer sizing, buffered SMILES loading, and the pre-Python-3.14 CPU-count fallback. |
| benchmarks/conformer_rmsd_bench.py | Replaces the multiprocessing CPU count with the shared affinity-aware helper. |
| benchmarks/tfd_bench.py | Uses the shared CPU-count helper while retaining the existing half-CPU worker default. |
| benchmarks/tfd_prepare_mols.py | Consolidates default worker calculation through the shared CPU-count helper. |
Reviews (1): Last reviewed commit: "Consolidate more benchmark code, make ff..." | Re-trigger Greptile
evasnow1992
approved these changes
Jul 31, 2026
evasnow1992
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the consolidation. Changes are clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated CPU count with fallback for older python (< 3.13).
Added pre-run checks for MMFF/UFF forcefield compatibility so we don't choke on inputs with a few bad molecules.