Align nvMolKit skill with BioNeMo expected representation and add evals. - #232
Align nvMolKit skill with BioNeMo expected representation and add evals. #232scal444 wants to merge 4 commits into
Conversation
Signed-off-by: Kevin Boyd <kboyd@nvidia.com>
|
| Filename | Overview |
|---|---|
| nvmolkit/tests/test_skill.py | Path constants updated and two new tests added: schema validation for evals.json and coverage check for trigger_evals.json. |
| skills/nvmolkit-usage/evals/evals.json | New file: 11 portable eval definitions covering installation, porting, from-scratch workflows, performance diagnosis, and autotuning scenarios. |
| skills/nvmolkit-usage/evals/trigger_evals.json | New file: 5 trigger eval entries (3 positive, 2 negative) to validate skill routing decisions. |
| src/fingerprint_similarity_device.cuh | Replaces cuda::std::min/max with the project-local cubMin{}/cubMax{} functors from cub_helpers.cuh; semantics are preserved across CCCL versions. |
| tests/test_fmcs_primitives.cu | Include paths corrected to src/mcs/fmcs_cuda/ and src/mcs/mcs_common/ to reflect the actual source tree layout. |
| README.md | Path reference updated from agent-skills/nvmolkit-usage/ to skills/nvmolkit-usage/. |
| docs/agent_skill.rst | Documentation link updated to match the new skills/nvmolkit-usage/ directory path. |
Reviews (3): Last reviewed commit: "Fix include check" | Re-trigger Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Signed-off-by: Matthew Neba <mattneba4343@gmail.com>
evasnow1992
left a comment
There was a problem hiding this comment.
Changes look good to me. Thank you!
This will be consumed by https://github.com/NVIDIA-BioNeMo/bionemo-agent-toolkit