Repository navigation
Conversation
wakamex
changed the title
Drop the signed-in retry. yt-dlp would receive Google's rotated session cookies and discard them with its temporary jar while the app keeps replaying the old values, the pattern that revoked sessions in v0.2.0, and every retried download would be tied to the user's account. A failed Deno download no longer blocks yt-dlp setup or playback: the stream path uses Deno only when it is already installed and otherwise leaves yt-dlp to its own runtime discovery. Setup still fetches Deno, and the next launch retries a failed download. A working install is remembered, so tracks no longer spawn `deno --version` each time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit
MEDIA_ERR_SRC_NOT_SUPPORTEDand “Failed to load because no supported source was found” on Windows 11 with v0.5.1. Cached liked tracks played, but uncached search results and later radio tracks failed. yt-dlp rejected anonymous requests with a sign-in check, and the saved session also needed a JavaScript runtime to solve the player challenges.This installs Deno 2.8.3 from its official release, verifies its SHA-256, and explicitly selects it for playback and metadata lookups. Playback starts anonymously and retries sign-in rejections once with a temporary copy of the selected account's saved cookies. The copy is removed after use; yt-dlp cannot overwrite the encrypted account jar. Deno is updated with app releases, while yt-dlp keeps its existing self-update behavior.
I pinned 2.8.3 to retain the original macOS 10.15 minimum on Intel and macOS 11 on Apple Silicon. Deno 2.9 introduced a macOS 12 requirement. The pin meets yt-dlp's minimum of Deno 2.3.0, but 2.8 is outside Deno's current LTS line.
Related: #83, #85.