fix: xhamster crawler support for xhamster45.desi#166
Merged
NTFSvolume merged 11 commits intoApr 20, 2026
Conversation
NTFSvolume
reviewed
Apr 18, 2026
Owner
NTFSvolume
left a comment
NTFSvolume
left a comment
There was a problem hiding this comment.
I think it should be the other way around. We should prefer direct downloads over HLS.
HLS downloads are more complex and therefore more likely to fail + less efficient
The original code used to parse both xplayerSettings and xplayerSettings2 but I removed xplayerSettings cause their MP4s were always a 403. I assume that why you gave priority to HLS?
It's that case I think is better to:
- Parse formats from
xplayerSettings2(HLS and MP4) - Parse only HLS formats from
xplayerSettings - Download the best MP4. It's none available, fallback to the best HLS
- Parsing only HLS from xplayerSettings - Parsing HLS and MP4 from xplayerSettings2 - Downloading best MP4 as default behaviour. If none available, fallback to the best HLS
Owner
|
|
NTFSvolume
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xHamster crawler failed on xhamster45.desi due to different JSON structure using xplayerSettings instead of xplayerSettings2.