ci: allowlist translated READMEs in hardcoded-URL check - #157
Merged
NetworkTheoryAppliedResearchInstitute merged 1 commit intoSep 8, 2026
Merged
Conversation
The P2-002 translation drafts (README.{ar,es,fr,hi,tok,zh}.md) mirror the
English README's localhost examples. README.md is already allowlisted; the
translations were not, so scripts/list-hardcoded-urls.sh has failed on every
PR since they merged (#145). Add the six translated READMEs to the allowlist.
Simulated locally: 0 matches remain outside the allowlist.
Signed-off-by: Jodson Graves <info@ntari.org>
NetworkTheoryAppliedResearchInstitute
deleted the
ci/allowlist-translated-readmes
branch
September 8, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/list-hardcoded-urls.shgreps the whole tree and has failed on every PR since the P2-002 translation drafts merged (#145): the translated READMEs carry the samehttp://localhost:*examples asREADME.md, which is already allowlisted.What
Adds the six translated READMEs to
scripts/hardcoded-url-allowlist.txt. No script logic changed.Verified
Ran the check's grep pipeline locally against
mainwith the new allowlist: 0 matches remain.This unblocks a truthful CI signal on the open Dependabot PRs (#149–#156) and the consolidated dependency PR that follows.