🛡️ Sentinel: [CRITICAL] Fix Process pipe deadlock DoS

[NSEvent]

🚨 Severity: CRITICAL
💡 Vulnerability: When spawning a child Process (NSTask) and reading its output via a Pipe, waiting for the process to exit (waitUntilExit()) before draining the output pipe buffer creates a race condition. If the output exceeds the OS pipe buffer (~64KB), the child process hangs waiting for the buffer to empty, and the parent hangs waiting for the child to exit, causing a complete application deadlock (Denial of Service).
🎯 Impact: Automation scripts, shell commands, or integration processes that produce large text output will randomly and permanently freeze the host application.
🔧 Fix: Swapped the order to ensure readDataToEndOfFile() on the pipe's file handle is called before waitUntilExit(). This guarantees the buffer is continuously drained until the child process closes its stdout streams, avoiding the deadlock entirely. Fix applied across both AutomationExecutor.swift and OBSWebSocketLiveIntegrationTests.swift.
✅ Verification: git diff confirms changes are correctly applied and a static parser verifies syntax brackets are structurally balanced. Code review passed.

---

PR created automatically by Jules for task 11519980697322531615 started by @NSEvent

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@NSEvent, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e9c6e59-5f55-4ee4-b6c8-8d1d52e1ae59

📥 Commits

Reviewing files that changed from the base of the PR and between 8821423 and 6611fe3.

📒 Files selected for processing (2)

• TriggerKit/Sources/TriggerKitRuntime/AutomationExecutor.swift
• XboxControllerMapper/XboxControllerMapperTests/OBSWebSocketLiveIntegrationTests.swift

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-pipe-deadlock-11519980697322531615

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}