Skip to content

🛡️ Sentinel: Fix DoS pipe deadlock in shell execution #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NSEvent wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🛡️ Sentinel: Fix DoS pipe deadlock in shell execution #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fcebc5
🛡️ Sentinel: Fix pipe deadlock DoS in AutomationExecutor
google-labs-jules[bot] Jul 14, 2026
cff26a5
🛡️ Sentinel: Fix DoS pipe deadlock in AutomationExecutor
google-labs-jules[bot] Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions TriggerKit/Sources/TriggerKitRuntime/AutomationExecutor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,9 +354,8 @@ public final class AutomationExecutor {
} catch {
return .failure("\(name) launch failed: \(error.localizedDescription)")
}
process.waitUntilExit()

let data = pipe.fileHandleForReading.readDataToEndOfFile()
process.waitUntilExit()
let output = String(data: data, encoding: .utf8)?
.trimmingCharacters(in: .whitespacesAndNewlines) ?? ""

Expand Down Expand Up @@ -731,11 +730,11 @@ private final class ShellCommandRunner: @unchecked Sendable {
pgrep.standardError = FileHandle.nullDevice
do {
try pgrep.run()
pgrep.waitUntilExit()
} catch {
return []
}
let data = pipe.fileHandleForReading.readDataToEndOfFile()
pgrep.waitUntilExit()
let output = String(data: data, encoding: .utf8) ?? ""
return output
.split(whereSeparator: \.isNewline)
Expand Down
Loading