🎨 Palette: Improve accessibility of list action buttons#84
Conversation
Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughSwiftUI icon-only list actions now provide contextual ChangesDynamic accessibility labels
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ChordSequenceListViews.swift`:
- Around line 118-127: Update the context-menu action Label strings in the row
views, including the additional sequence-action block, to include the associated
chord or sequence name just like the trailing buttons. Use a suitable fallback
when the name is empty, while preserving the existing action titles and
behavior.
In
`@XboxControllerMapper/XboxControllerMapper/Views/MainWindow/GestureListViews.swift`:
- Around line 81-91: Update the context-menu accessibility Label strings for the
edit and clear actions in the gesture row to include gestureType.displayName,
matching the contextualized .help and .accessibilityLabel values while
preserving the existing action behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 08f90e4c-9314-450d-bcc9-eb786169aca3
📒 Files selected for processing (5)
.Jules/palette.mdXboxControllerMapper/XboxControllerMapper/Views/Macros/MacroListView.swiftXboxControllerMapper/XboxControllerMapper/Views/MainWindow/ChordSequenceListViews.swiftXboxControllerMapper/XboxControllerMapper/Views/MainWindow/GestureListViews.swiftXboxControllerMapper/XboxControllerMapper/Views/Scripts/ScriptListView.swift
| .help("Edit \(gestureType.displayName)") | ||
| .accessibilityLabel("Edit \(gestureType.displayName)") | ||
|
|
||
| if mapping?.hasAction == true { | ||
| Button(action: onClear) { | ||
| Image(systemName: "trash") | ||
| .foregroundColor(.red.opacity(0.8)) | ||
| } | ||
| .buttonStyle(.borderless) | ||
| .help("Clear") | ||
| .accessibilityLabel("Clear") | ||
| .help("Clear \(gestureType.displayName)") | ||
| .accessibilityLabel("Clear \(gestureType.displayName)") |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Contextualize the gesture context-menu actions too.
The new icon-button labels include the gesture name, but the context menu still announces generic “Edit Gesture” and “Clear Action” labels. Include gestureType.displayName in those Label strings so the contextual accessibility behavior is consistent across all row actions.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@XboxControllerMapper/XboxControllerMapper/Views/MainWindow/GestureListViews.swift`
around lines 81 - 91, Update the context-menu accessibility Label strings for
the edit and clear actions in the gesture row to include
gestureType.displayName, matching the contextualized .help and
.accessibilityLabel values while preserving the existing action behavior.
…pilation) Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
1 participant
💡 What: Added dynamic item names to the
.help()and.accessibilityLabel()strings for list row action buttons (Edit, Delete, Clear) inMacroListView,ChordSequenceListViews,GestureListViews, andScriptListView.🎯 Why: Previously, VoiceOver would just read "Edit" or "Delete" identically for every row, making it impossible for visually impaired users to know which list item they were operating on. Adding the name provides necessary context.
♿ Accessibility: Major VoiceOver improvement for all main list interfaces, disambiguating repeated action buttons.
PR created automatically by Jules for task 3556881315248094765 started by @NSEvent
Summary by CodeRabbit
Accessibility
Documentation