🎨 Palette: Add dynamic accessibility context to Community Profile checkbox#64
Open
NSEvent wants to merge 3 commits into
Open
🎨 Palette: Add dynamic accessibility context to Community Profile checkbox#64NSEvent wants to merge 3 commits into
NSEvent wants to merge 3 commits into
Conversation
Adds `.help()` and `.accessibilityLabel()` modifiers with dynamic context (the profile's display name) to the icon-only selection button in the `CommunityProfileRow` list view. This improves UX for VoiceOver users and provides visual tooltips on hover. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Contributor
|
Important Review skippedToo many files! This PR contains 188 files, which is 38 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (188)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe PR adds dynamic ChangesCommunity Profile Checkbox Accessibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds `.help()` and `.accessibilityLabel()` modifiers with dynamic context (the profile's display name) to the icon-only selection button in the `CommunityProfileRow` list view. This improves UX for VoiceOver users and provides visual tooltips on hover. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.helpand.accessibilityLabelmodifiers to the checkmark selection button in the Community Profiles list.circle/checkmark.circle.fill) lacked a tooltip for hover context and had no screen reader label, leaving VoiceOver users without any context on what the button toggles. Additionally, context uses theprofileInfo.displayNameto disambiguate identical-looking toggles in the list.PR created automatically by Jules for task 2321091371159725096 started by @NSEvent
Summary by CodeRabbit