Skip to content

updated_static_attributes_workflow#67

Open
ajkhattak wants to merge 12 commits into
NOAA-OWP:masterfrom
ajkhattak:master
Open

updated_static_attributes_workflow#67
ajkhattak wants to merge 12 commits into
NOAA-OWP:masterfrom
ajkhattak:master

Conversation

@ajkhattak
Copy link
Copy Markdown

This PR adds support for dynamic allocation of static attributes.
Previously, the behavior was hardcoded to use only two static attributes (slope and elevation), which limited applicability to trained models expecting exactly those attributes.

Updated behavior:
Static attributes are now read dynamically from the configuration file.
The provided attributes are validated against the attributes required by the trained model.
Different trained models within LSTM ensemble runs can now use different numbers and sets of static attributes.

Additions

  • dynamically reading static attributes
  • Updated tests and added a Jupyter Notebook demonstrating an example LSTM run.
  • Partially updated the documentation

Removals

  • Hardcoded static attributes

Changes

  • None

Testing

  1. Tested in a standalone mode and within ngen. No changes to the fundamental behavior of the model

Todos

  • Updated documentation

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

@ajkhattak ajkhattak requested review from aaraney and hellkite500 May 15, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant