Skip to content

NGWPC NWM PI-3 Formulation Selection Delivery 2026-02-25#66

Open
cmaynard-ngwpc wants to merge 21 commits into
NOAA-OWP:masterfrom
NGWPC:ngwpc-3.1.2.1.0
Open

NGWPC NWM PI-3 Formulation Selection Delivery 2026-02-25#66
cmaynard-ngwpc wants to merge 21 commits into
NOAA-OWP:masterfrom
NGWPC:ngwpc-3.1.2.1.0

Conversation

@cmaynard-ngwpc
Copy link
Copy Markdown

This pull request enhances the EWTS logging framework and LSTM integration, improves unit test workflow reliability, and expands model outputs. It adds the new lstm_ewts package with accompanying unit tests, refines logging consistency and correctness, and updates CI workflows to ensure unit tests install dependencies reliably.


Additions

  • Added the lstm_ewts package, including initial unit tests.
  • Introduced precipitation as a new model output variable.
  • Added an initialization info-level log message to improve runtime visibility.

Changes

  • Updated unit test GitHub Actions workflows to fix and standardize pip install commands.
  • Refactored logging to use a named logger (LOG), replacing direct logger. calls for consistency across EWTS components.
  • Fixed debug log statements to correctly use format specifiers.
  • Updated code to consistently use the lstm_ewts package where applicable.

Removals

  • None.

cmaynard-ngwpc and others added 21 commits June 19, 2025 16:36
Add Error and Warning Trapping System

See merge request NGWPC/nwm-ngen/lstm!3
Merge development into release-candidate for release 3.1.1.0.0-rc1

See merge request NGWPC/nwm-ngen/lstm!4
Add license file

See merge request NGWPC/nwm-ngen/lstm!5
Add previous licensing verbiage

See merge request NGWPC/nwm-ngen/lstm!6
Merge release-candidate into development for release 3.1.1.0.0-rc2

See merge request NGWPC/nwm-ngen/lstm!7
…o 'LOG.' to be consistent across EWTS loggers.
Add precipitation as an output variable
Add building the lstm_ewts package
Merge development into ngwpc-candidate for release 3.1.2.1.0-rc1
Merge ngwpc-candidate into ngwpc-release for release 3.1.2.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants