parallel nfu building + CI clarity changes#410
Open
ilaflott wants to merge 8 commits into
Open
Conversation
Under make -j, make scheduled two independent jobs that both compiled libnfu/nfu.F90: the .F90.o rule (producing nfu.o for libnfu.a) and the .F90.$(FC_MODEXT) suffix rule (producing nfu_mod.mod for nfu_compress.o's prerequisite). Because AM_FCFLAGS uses $(FC_MODOUT)$(@d), both gfortran processes wrote to the same libnfu/nfu_mod.mod0 temp file and raced to rename it, causing the intermittent error: f951: Fatal Error: Cannot rename module file 'libnfu/nfu_mod.mod0' to 'libnfu/nfu_mod.mod': No such file or directory Fix by adding an explicit no-op rule in lib/libnfu/local.mk: libnfu/nfu_mod.$(FC_MODEXT): libnfu/nfu.$(OBJEXT) @: This overrides the .F90.$(FC_MODEXT) suffix rule so nfu.F90 is compiled only once. nfu_mod.mod is treated as a side effect of building nfu.o, and nfu_compress.o waits for it via the existing prerequisite. Also replace the duplicate clean-local rule in local.mk (which produced a make warning) with CLEANFILES += entries, and add CLEANFILES = in lib/Makefile.am to initialise the variable before local.mk uses +=. Fix a typo in tools/simple_hydrog/lakes/Makefile.am: the prerequisite horiz_intrep.$(OBJEXT) did not match any source file; corrected to horiz_interp.$(OBJEXT). Closes: NOAA-GFDL#405
The Fortran compiler writes .mod files into .mods/ subdirectories (src/.mods/, src/plevel/.mods/) but clean-local never removed those directories, causing distcleancheck to report leftover files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ilaflott
changed the title
whitespace for readability and printout remote+branch for explicit clarity and sanity check
ilaflott
force-pushed
the
nfu.parallel.and.CI.clarity
branch
from
23e0b94 to
353e49b
Compare
Member
Author
|
i think that's it.
|
ilaflott
commented
Jun 11, 2026
Member
Author
There was a problem hiding this comment.
removing pre-merge, leaving for now to assist with review
8 tasks
Member
Author
|
this is ready for a solid review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: truefor prep of node20 retirement on the 19thworkflow now prints out the remote+branch being used, ty @singhd789 for these bitsoh right, test cloud runner is on parallel works, different rules...Closes #405 and #408
How Has This Been Tested?
see checks
Checklist:
make distcheckpasses