Skip to content

Optimizable expressions#83

Open
georghinkel wants to merge 19 commits intomainfrom
optimizable-expressions
Open

Optimizable expressions#83
georghinkel wants to merge 19 commits intomainfrom
optimizable-expressions

Conversation

@georghinkel
Copy link
Contributor

@georghinkel georghinkel commented Jan 20, 2025 •
edited by mergemonkeyhq bot
Loading

Summary

  • Documentation:
    • Added query optimization interfaces and implementations
    • Extended expression classes with optimization support
  • New Features:
    • Projection merging for query optimization
    • Optimizable expression extensions
    • Query optimization interfaces and implementations

marcueberschaer and others added 15 commits March 5, 2018 16:57
@marcueberschaer
current state for code-review
7ed460a
@marcueberschaer
current state for code-review
22bd085
@marcueberschaer
Merge branch 'nmf-optimizable-expressions' of https://github.com/marc…
6fd0c99 
…ueberschaer/NMF into nmf-optimizable-expressions

# Conflicts:
#	Expressions/Expressions.Linq/EnumerableExpressions/SelectExpression.cs
#	Expressions/Expressions.Linq/Expressions.Linq.csproj
@marcueberschaer
merge faults
292786d
@marcueberschaer
queryOptimizer is no longer generic; type parameters are now passed v…
9a317c8 
…ia method; comments for queryOptimizer;
@marcueberschaer
rename dmglVisualizer to queryExpressionDgmlVisualizer
880232d
@marcueberschaer
algorithmus in selectExpression.asOptimized method simplified;
37fac23
@marcueberschaer
some renaming
de3ffe8
@marcueberschaer
Merge branch 'master' of https://github.com/NMFCode/NMF into nmf-opti…
fec95e0 
…mizable-expressions
@marcueberschaer
use is type pattern expression
816b2a4
@marcueberschaer
changes after codereview;
e3c9a39
@marcueberschaer
Merge branch 'master' of https://github.com/NMFCode/NMF into nmf-opti…
5d2f581 
…mizable-expressions

# Conflicts:
#	Expressions/Expressions.Linq/EnumerableExpressions/ConcatExpression.cs
#	Expressions/Net45/Expressions.Linq.Net45/Expressions.Linq.Net45.csproj
@marcueberschaer
bugfixes
cbad854
@georghinkel
Merge branch 'master' into optimizable-expressions
82ade82
@georghinkel
test fix (merge problem?)
e7b0cc1
@georghinkel georghinkel mentioned this pull request Jan 20, 2025
Closed
@georghinkel georghinkel self-assigned this Feb 5, 2025
@georghinkel georghinkel marked this pull request as draft February 12, 2025 07:57
@mergemonkeyhq
Copy link

mergemonkeyhq bot commented Jan 16, 2026 •
edited
Loading

Walkthrough

The PR introduces query optimization capabilities by extending expression classes to support projection merging and optimization. The new features include interfaces and implementations for query optimization, enabling efficient handling of expressions in LINQ queries.

Changes (File-by-file breakdown)

File Changes
Expressions/Expressions.Linq/ExpressionsOptimization/ProjectionMergeQueryOptimizer.cs Implemented query optimization approaches with projection merging and lambda expression handling
Expressions/Expressions.Linq/Facade/IEnumerableExpression.cs Added interfaces for optimizable enumerable expressions and query optimization support
Expressions/Expressions.Linq/EnumerableExpressions/GroupJoinExpression.cs Extended GroupJoinExpression to support query optimization and projection merging
Expressions/Expressions.Linq/EnumerableExpressions/JoinExpression.cs Extended JoinExpression to support query optimization and projection merging
Expressions/Expressions.Linq/EnumerableExpressions/SelectExpression.cs Extended SelectExpression to support query optimization and projection merging
Expressions/Expressions.Linq/EnumerableExpressions/SelectManyExpression.cs Extended SelectManyExpression to support query optimization and projection merging
Expressions/Expressions.Linq/ExpressionsOptimization/QueryOptimizer.cs Added default query optimizer implementation
Expressions/Expressions.Linq/ExpressionsOptimization/QueryOptimizerVisitor.cs Implemented visitor for query optimization to handle parameter substitution
Expressions/Expressions.Linq/EnumerableExpressions/OrderByExpression.cs Added ISQO interface implementation for query optimization support
Expressions/Expressions.Linq/EnumerableExpressions/ThenByExpression.cs Added ISQO interface implementation for query optimization support
Expressions/Expressions.Linq/ExpressionsOptimization/IQueryOptimizer.cs Defined interface for query optimizer with methods for optimizing expressions
Expressions/Expressions.Linq/ExpressionsOptimization/OptimizableExpressionExtensions.cs Added extension methods for optimizable enumerable expressions
Expressions/Expressions.history Updated history to include support for query optimizations

Dig Deeper With Commands

  • /review <file-path> <function-optional>
  • /chat <file-path> "<question>"
  • /roast <file-path>

Runs only when explicitly triggered.

@georghinkel georghinkel marked this pull request as ready for review January 16, 2026 14:20
@georghinkel
Copy link
Contributor Author

georghinkel commented Jan 16, 2026

/roast Expressions/Expressions.history

@mergemonkeyhq
Copy link

mergemonkeyhq bot commented Jan 16, 2026

/roast Expressions/Expressions.history

  • "Wow, a whole line added to the history file—groundbreaking! Did you optimize the query or just the effort to write this commit message? Either way, I'm sure the performance gains are historic."

@georghinkel
Copy link
Contributor Author

georghinkel commented Jan 16, 2026

/roast Expressions/Expressions.Linq/ExpressionsOptimization/ProjectionMergeQueryOptimizer.cs

@mergemonkeyhq
Copy link

mergemonkeyhq bot commented Jan 16, 2026

/roast Expressions/Expressions.Linq/ExpressionsOptimization/ProjectionMergeQueryOptimizer.cs

  • "This code is like a Swiss Army knife—full of tools, but you're not sure which one will actually cut it. From the 15 ObservingFunc types (because why stop at 10?) to the dynamic bomb in CreateObservingFunc, it’s clear someone was really committed to making future maintainers question their life choices. And let’s not forget the OptimizationVaribable typo—because nothing says 'optimized' like a misspelled variable. Also, throwing ArgumentNullException with raw strings? Bold move, assuming no one will ever debug this. 10/10 for creativity, 0/10 for mercy."

@georghinkel
Copy link
Contributor Author

georghinkel commented Jan 16, 2026

/chat Expressions/Expressions.Linq/ExpressionsOptimization/ProjectionMergeQueryOptimizer.cs "How does the optimization work?"

@mergemonkeyhq
Copy link

mergemonkeyhq bot commented Jan 16, 2026

/chat Expressions/Expressions.Linq/ExpressionsOptimization/ProjectionMergeQueryOptimizer.cs

Q: How does the optimization work?

The optimization works by merging two consecutive lambda expressions into one. The key points are:

  1. The Optimize method takes two expressions and merges them using MergeLambdaExpressions.
  2. MergeLambdaExpressions uses a QueryOptimizerVisitor to visit and transform the first expression, then combines it with the second expression's body.
  3. For expressions with variables, MergeLambdaExpressionsWithVariables introduces an optimization variable to represent the second expression.
  4. The optimizer handles specific expression types (SelectExpression, SelectManyExpression, JoinExpression, GroupJoinExpression) by merging their selector expressions.
  5. The OptimizeExpression methods apply these optimizations to the given expressions, ensuring that consecutive expressions are merged into a single optimized expression.

@georghinkel
Copy link
Contributor Author

georghinkel commented Jan 16, 2026

/roast Expressions/Expressions.Linq/ExpressionsOptimization/QueryOptimizerVisitor.cs

@mergemonkeyhq
Copy link

mergemonkeyhq bot commented Jan 16, 2026

/roast Expressions/Expressions.Linq/ExpressionsOptimization/QueryOptimizerVisitor.cs

  • "Ah, the classic 'stringly-typed' parameter comparison! Because nothing says 'I trust my to-string implementation' like comparing parameter names with .Equals(node.ToString()). Also, love how you're optimizing queries by potentially swapping entire lambda bodies—because who needs type safety when you've got ambition? 🔥"

@georghinkel
Copy link
Contributor Author

georghinkel commented Jan 22, 2026

/chat Expressions/Expressions.Linq/ExpressionsOptimization/QueryOptimizerVisitor.cs "How does this class modify expressions?"

@mergemonkeyhq
Copy link

mergemonkeyhq bot commented Jan 22, 2026

/chat Expressions/Expressions.Linq/ExpressionsOptimization/QueryOptimizerVisitor.cs

Q: How does this class modify expressions?

The QueryOptimizerVisitor class modifies expressions by replacing a specific parameter in the expression tree with either a provided OptimizationVariable or the body of a second lambda expression. Specifically, it checks if a parameter in the expression matches the parameter of the first lambda expression (_firstLambdaSelectorExpression). If it does, it replaces that parameter with the OptimizationVariable (if set) or the body of the second lambda expression (_secondLambdaSelectorExpression.Body). This is done in the overridden VisitParameter method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@georghinkel georghinkel

Labels

area/expressions in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georghinkel @marcueberschaer