add synchronization package, improve handling of optional features#126
Merged
georghinkel merged 1 commit intomainfrom Feb 17, 2026
Merged
add synchronization package, improve handling of optional features#126georghinkel merged 1 commit intomainfrom
georghinkel merged 1 commit intomainfrom
Conversation
WalkthroughThe PR introduces a new synchronization package and refactors the parser to use dedicated helper methods for offset calculations and edit creation, improving readability and maintainability. It also adds defensive null checks and type filtering to enhance robustness across LSP mapping and collection change tracking. Metadata, tags, and history logs are updated to reflect the new functionality. Changes (File-by-file breakdown)
Sequence DiagramsequenceDiagram
participant Parser
participant Helper
participant TextEdit
participant LspMapper
participant Listener
Parser->>Helper: CalculateStartOffset(...)
Parser->>Helper: CalculateEndOffset(...)
Parser->>Helper: CreateEdit(...)
Helper->>TextEdit: new TextEdit(...)
LspMapper->>LspMapper: if changes == null return null
Listener->>Listener: foreach movedItems.OfType<T>()
Listener->>Listener: foreach replacingItems.OfType<T>()
Listener->>Listener: foreach replacedItems.OfType<T>()
Dig Deeper With Commands
Runs only when explicitly triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by MergeMonkey