Repository navigation
Judge pre-1.0 documents by their version, not by 1.0 field rules - #2
Merged
Merged
Conversation
…ield rules A 0.4 document failed agent.protocols for a missing description, which only 1.0 requires. Now a non-1.x document fails version.compatible (an error, since a 1.0-only agent must not use it), passes when supported_versions lists a 1.x document, and skips the 1.0 field and OAuth rules with a note. Rules for what spec 3.4 keeps stable across versions still run. Refs #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
What changed
version.compatibleis now an error. A document whoseprotocol_versionisn't 1.x fails it, because before 1.0 a version is compatible only with the same minor version (spec 3.4), so an agent that implements only 1.0 must not use it. The fix points to the changelog.supported_versionslists a 1.x document,version.compatiblepasses, since a 1.0 agent uses that document instead.allVersions(transport, JSON,protocol_version,supported_versions, which spec 3.4 keeps stable across versions) still run.docs/SPEC-NOTES.mdrecords the decision.Before / after on a Shopify store (0.4 document)
Before:
FAIL agent.protocols(missingdescription) plusWARN version.compatible. The error was a false positive under 0.4.After: only
FAIL version.compatible, with the fix; everything 1.0-specific is skipped. Score 75.Tests
328 passing. New: version-handling suite in
tests/check.test.ts, extraversion.compatiblecases, and a Shopify-shaped fixtureinvalid/pre-1.0-version.json(fictional domain).