Skip to content

Judge pre-1.0 documents by their version, not by 1.0 field rules - #2

Merged
NHTanvir merged 2 commits into
masterfrom
fix/pre-1.0-documents
Nov 17, 2026
Merged

NHTanvir merged 2 commits into
masterfrom
fix/pre-1.0-documents

Conversation

@NHTanvir

Copy link
Copy Markdown
Owner

Closes #1

What changed

  • version.compatible is now an error. A document whose protocol_version isn't 1.x fails it, because before 1.0 a version is compatible only with the same minor version (spec 3.4), so an agent that implements only 1.0 must not use it. The fix points to the changelog.
  • If supported_versions lists a 1.x document, version.compatible passes, since a 1.0 agent uses that document instead.
  • For a non-1.x document, the 1.0 field rules and OAuth checks are skipped with a note, and no OAuth metadata is fetched. Rules marked allVersions (transport, JSON, protocol_version, supported_versions, which spec 3.4 keeps stable across versions) still run.
  • The verdict line now says "Poppy 1.0 Personal Agents".
  • docs/SPEC-NOTES.md records the decision.

Before / after on a Shopify store (0.4 document)

Before: FAIL agent.protocols (missing description) plus WARN version.compatible. The error was a false positive under 0.4.

After: only FAIL version.compatible, with the fix; everything 1.0-specific is skipped. Score 75.

Tests

328 passing. New: version-handling suite in tests/check.test.ts, extra version.compatible cases, and a Shopify-shaped fixture invalid/pre-1.0-version.json (fictional domain).

…ield rules

A 0.4 document failed agent.protocols for a missing description, which only
1.0 requires. Now a non-1.x document fails version.compatible (an error,
since a 1.0-only agent must not use it), passes when supported_versions lists
a 1.x document, and skips the 1.0 field and OAuth rules with a note. Rules
for what spec 3.4 keeps stable across versions still run.

Refs #1
@NHTanvir NHTanvir self-assigned this Nov 17, 2026
@NHTanvir
NHTanvir merged commit 26d63d7 into master Nov 17, 2026
4 checks passed
@NHTanvir
NHTanvir deleted the fix/pre-1.0-documents branch November 17, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check applies 1.0 field rules to pre-1.0 documents, giving false errors

1 participant