Upgrade to Storybook v9 - #270
Merged
colinrotherham merged 1 commit intoOct 7, 2025
Merged
Conversation
ricksmith130
force-pushed
the
NCRS-4111/NCRS-4106/Upgrade-of-react-storybook-and-scss
branch
from
September 22, 2025 10:49
c6321e0 to
0dadd5a
Compare
colinrotherham
force-pushed
the
NCRS-4111/NCRS-4106/Upgrade-of-react-storybook-and-scss
branch
from
September 29, 2025 14:07
c05cd45 to
a8e38ff
Compare
colinrotherham
force-pushed
the
NCRS-4111/NCRS-4106/Upgrade-of-react-storybook-and-scss
branch
from
September 30, 2025 16:37
a8e38ff to
69f160f
Compare
Collaborator
|
Rebased with |
colinrotherham
force-pushed
the
NCRS-4111/NCRS-4106/Upgrade-of-react-storybook-and-scss
branch
from
October 7, 2025 09:26
69f160f to
250b69e
Compare
colinrotherham
changed the title
colinrotherham
force-pushed
the
react
branch
2 times, most recently
from
October 7, 2025 10:08
c0bcb8b to
629cc59
Compare
colinrotherham
force-pushed
the
NCRS-4111/NCRS-4106/Upgrade-of-react-storybook-and-scss
branch
from
October 7, 2025 10:26
250b69e to
e15ef1e
Compare
Collaborator
|
Rebased with #273 to make sure both React v18 and v19 work together |
Comment on lines
+49
to
+55
| "typesVersions": { | ||
| "*": { | ||
| "react": [ | ||
| "node_modules/react/index.d.ts" | ||
| ] | ||
| } | ||
| }, |
Collaborator
There was a problem hiding this comment.
For my benefit @ricksmith130, what did this bit fix?
Collaborator
There was a problem hiding this comment.
Do we need this definition? it looks like it would be the default path for react types
Collaborator
There was a problem hiding this comment.
Let's remove it then we can get this merged and released
colinrotherham
force-pushed
the
NCRS-4111/NCRS-4106/Upgrade-of-react-storybook-and-scss
branch
from
October 7, 2025 15:57
e15ef1e to
b4ce964
Compare
colinrotherham
force-pushed
the
NCRS-4111/NCRS-4106/Upgrade-of-react-storybook-and-scss
branch
from
October 7, 2025 15:57
b4ce964 to
7350569
Compare
|
colinrotherham
self-requested a review
October 7, 2025 15:58
colinrotherham
approved these changes
Oct 7, 2025
colinrotherham
deleted the
NCRS-4111/NCRS-4106/Upgrade-of-react-storybook-and-scss
branch
October 7, 2025 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just upgrades to Storybook v9 and any changes that it requires. It has been manually tested thoroughly