Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lambdas/core-notifier-lambda/src/__tests__/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ export const mockResponse: SingleMessageResponse = {

export const validPdmEvent: PDMResourceAvailable = {
id: 'event-id-123',
source:
'/nhs/england/notify/development/dev-12345/data-plane/digitalletters/pdm',
plane: 'data',
source: '/nhs/england/notify/development/dev-12345/digitalletters/pdm',
specversion: '1.0',
type: 'uk.nhs.notify.digital.letters.pdm.resource.available.v1',
time: '2025-12-15T10:00:00Z',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ const createValidItemDequeuedBody = (
detail: {
specversion: '1.0',
id: `event-${messageReference}`,
source:
'/nhs/england/notify/development/primary/data-plane/digitalletters/queue',
plane: 'data',
source: '/nhs/england/notify/development/primary/digitalletters/queue',
subject: `message/${messageReference}`,
type: 'uk.nhs.notify.digital.letters.queue.item.dequeued.v1',
time: '2026-01-19T12:00:00Z',
Expand Down Expand Up @@ -319,7 +319,7 @@ describe('SQS Handler', () => {
specversion: '1.0',
id: 'event-001',
source:
'/nhs/england/notify/development/primary/data-plane/digitalletters/queue',
'/nhs/england/notify/development/primary/digitalletters/queue',
type: 'uk.nhs.notify.wrong.event.type.v1',
time: '2026-01-19T12:00:00Z',
data: {
Expand Down Expand Up @@ -386,7 +386,7 @@ describe('SQS Handler', () => {
specversion: '1.0',
id: 'event-001',
source:
'/nhs/england/notify/development/primary/data-plane/digitalletters/queue',
'/nhs/england/notify/development/primary/digitalletters/queue',
type: 'uk.nhs.notify.digital.letters.queue.item.dequeued.v1',
time: '2026-01-19T12:00:00Z',
data: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def create_downloaded_event_dict(event_id: str) -> Dict[str, str | int | Dict[st
"specversion": "1.0",
"source": (
"/nhs/england/notify/production/primary/"
'data-plane/digitalletters/mesh'
'digitalletters/mesh'
),
"subject": (
'customer/920fca11-596a-4eca-9c47-99f624614658/'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def create_invalid_sqs_record(event_id: str) -> Dict[str, str]:
'detail': {
'id': event_id,
'specversion': '1.0',
'source': '/nhs/england/notify/production/primary/data-plane/digitalletters/mesh',
'source': '/nhs/england/notify/production/primary/digitalletters/mesh',
'subject': (
'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/'
'769acdd4-6a47-496f-999f-76a6fd2c3959'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def create_valid_cloud_event():
return {
'id': str(uuid4()),
'specversion': '1.0',
'source': '/nhs/england/notify/development/primary/data-plane/digitalletters/mesh',
'source': '/nhs/england/notify/development/primary/digitalletters/mesh',
'subject': 'customer/00000000-0000-0000-0000-000000000000/recipient/00000000-0000-0000-0000-000000000000',
'type': 'uk.nhs.notify.digital.letters.mesh.inbox.message.received.v1',
'time': '2023-01-01T12:00:00Z',
Expand Down Expand Up @@ -159,7 +159,7 @@ def test_process_sqs_message_success(self, mock_datetime):

# Verify CloudEvent envelope fields
assert published_event['type'] == 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1'
assert published_event['source'] == '/nhs/england/notify/development/primary/data-plane/digitalletters/mesh'
assert published_event['source'] == '/nhs/england/notify/development/primary/digitalletters/mesh'
assert published_event['subject'] == 'customer/00000000-0000-0000-0000-000000000000/recipient/00000000-0000-0000-0000-000000000000'
assert published_event['time'] == '2025-11-19T15:30:45+00:00'
assert 'id' in published_event
Expand Down
3 changes: 1 addition & 2 deletions lambdas/mesh-poll/mesh_poll/processor.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,8 @@ def __init__(self, **kwargs):

environment = 'development'
deployment = 'primary'
plane = 'data-plane'
self.__cloud_event_source = (
f'/nhs/england/notify/{environment}/{deployment}/{plane}/'
f'/nhs/england/notify/{environment}/{deployment}/'
'digitalletters/mesh'
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ describe('mapper', () => {
specversion: '1.0',
id: 'mocked-uuid-12345',
subject: `customer/${senderId}/recipient/${messageReference}`,
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
source: '/nhs/england/notify/production/primary/digitalletters/print',
plane: 'data',
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
time: '2024-01-15T10:30:00.000Z',
Expand Down Expand Up @@ -99,8 +99,8 @@ describe('mapper', () => {
specversion: '1.0',
id: 'mocked-uuid-12345',
subject: `customer/${senderId}/recipient/${messageReference}`,
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
plane: 'data',
source: '/nhs/england/notify/production/primary/digitalletters/print',
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
type: 'uk.nhs.notify.digital.letters.print.file.quarantined.v1',
time: '2024-01-15T10:30:00.000Z',
Expand Down
8 changes: 4 additions & 4 deletions lambdas/move-scanned-files-lambda/src/domain/mapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ export function createFileSafeEvent(
specversion: '1.0',
id: randomUUID(),
subject: `customer/${senderId}/recipient/${messageReference}`,
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print', // Note CCM-13892.
plane: 'data',
source: '/nhs/england/notify/production/primary/digitalletters/print', // Note CCM-13892.
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01', // Note CCM-14255.
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
time: new Date().toISOString(),
Expand All @@ -37,8 +37,8 @@ export function createFileQuarantinedEvent(
specversion: '1.0',
id: randomUUID(),
subject: `customer/${senderId}/recipient/${messageReference}`,
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print', // Note CCM-13892.
plane: 'data',
source: '/nhs/england/notify/production/primary/digitalletters/print', // Note CCM-13892.
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01', // Note CCM-14255.
type: 'uk.nhs.notify.digital.letters.print.file.quarantined.v1',
time: new Date().toISOString(),
Expand Down
4 changes: 2 additions & 2 deletions lambdas/pdm-poll-lambda/src/__tests__/test-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import {
const baseEvent = {
id: '550e8400-e29b-41d4-a716-446655440001',
specversion: '1.0',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/pdm',
source: '/nhs/england/notify/production/primary/digitalletters/pdm',
subject:
'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/769acdd4-6a47-496f-999f-76a6fd2c3959',
plane: 'data',
type: 'uk.nhs.notify.digital.letters.pdm.resource.submitted.v1',
time: '2023-06-20T12:00:00Z',
recordedtime: '2023-06-20T12:00:00.250Z',
Expand Down
4 changes: 2 additions & 2 deletions lambdas/pdm-uploader-lambda/src/__tests__/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { MESHInboxMessageDownloaded } from 'digital-letters-events';
export const mockEvent: MESHInboxMessageDownloaded = {
id: 'a449d419-e683-4ab4-9291-a0451b5cef8e',
specversion: '1.0',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/mesh',
source: '/nhs/england/notify/production/primary/digitalletters/mesh',
plane: 'data',
subject:
'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/769acdd4-6a47-496f-999f-76a6fd2c3959',
type: 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('SQS Handler', () => {
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-pdf-analysed-data.schema.json',
type: 'uk.nhs.notify.digital.letters.print.pdf.analysed.v1',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
'/nhs/england/notify/production/primary/digitalletters/print',
data: {
senderId: fileSafeEvent.data.senderId,
messageReference: fileSafeEvent.data.messageReference,
Expand Down
4 changes: 2 additions & 2 deletions lambdas/print-analyser/src/__tests__/test-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
export const fileSafeEvent: FileSafe = {
id: '550e8400-e29b-41d4-a716-446655440001',
specversion: '1.0',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
source: '/nhs/england/notify/production/primary/digitalletters/print',
plane: 'data',
subject:
'letter-origin/digital-letters/letter/f47ac10b-58cc-4372-a567-0e02b2c3d479',
type: 'uk.nhs.notify.digital.letters.print.file.safe.v1',
Expand Down Expand Up @@ -57,4 +57,4 @@
});

export const fivePagePdf = () =>
readFileSync(path.join(__dirname, 'five-page.pdf'));

Check warning on line 60 in lambdas/print-analyser/src/__tests__/test-data.ts

View workflow job for this annotation

GitHub Actions / Test stage / Linting

Found readFileSync from package "node:fs" with non literal argument at index 0
3 changes: 1 addition & 2 deletions lambdas/print-analyser/src/apis/sqs-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ function generateUpdatedEvent(event: FileSafe, pdfInfo: PdfInfo): PDFAnalysed {
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-pdf-analysed-data.schema.json',
type: 'uk.nhs.notify.digital.letters.print.pdf.analysed.v1',
// NOTE: CCM-13892 Generate event digital letters source property from scratch
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
source: '/nhs/england/notify/production/primary/digitalletters/print',
data: {
senderId,
messageReference,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ const createValidEvent = (overrides = {}): PDFAnalysed => ({
type: 'uk.nhs.notify.digital.letters.print.pdf.analysed.v1',
dataschema:
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-pdf-analysed-data.schema.json',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
plane: 'data',
source: '/nhs/england/notify/production/primary/digitalletters/print',
specversion: '1.0',
traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01',
severitynumber: 2,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe('SQS Handler', () => {
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-letter-transitioned-data.schema.json',
type: 'uk.nhs.notify.digital.letters.print.letter.transitioned.v1',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
'/nhs/england/notify/production/primary/digitalletters/print',
data: {
senderId: acceptedLetterEvent.data.origin.subject.split('/')[1],
messageReference:
Expand Down Expand Up @@ -82,7 +82,7 @@ describe('SQS Handler', () => {
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-letter-transitioned-data.schema.json',
type: 'uk.nhs.notify.digital.letters.print.letter.transitioned.v1',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
'/nhs/england/notify/production/primary/digitalletters/print',
data: {
senderId: failedLetterEvent.data.origin.subject.split('/')[1],
messageReference:
Expand Down
3 changes: 1 addition & 2 deletions lambdas/print-status-handler/src/apis/sqs-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ function generateUpdatedEvent(event: LetterEvent): PrintLetterTransitioned {
'https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-letter-transitioned-data.schema.json',
type: 'uk.nhs.notify.digital.letters.print.letter.transitioned.v1',
// NOTE: CCM-13892 Generate event digital letters source property from scratch
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/print',
source: '/nhs/england/notify/production/primary/digitalletters/print',
data: {
senderId,
messageReference,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import { DigitalLettersEvent } from 'types/events';
export const digitalLettersEvent = {
id: '550e8400-e29b-41d4-a716-446655440001',
specversion: '1.0',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/pdm',
source: '/nhs/england/notify/production/primary/digitalletters/pdm',
subject:
'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/769acdd4-6a47-496f-999f-76a6fd2c3959',
type: 'uk.nhs.notify.digital.letters.pdm.resource.submitted.v1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ const createMockSQSRecord = (
id: event.id || mockUuid,
source:
event.source ||
'/nhs/england/notify/development/primary/data-plane/digitalletters/reporting',
'/nhs/england/notify/development/primary/digitalletters/reporting',
plane: 'data',
specversion: event.specversion || '1.0',
type:
event.type ||
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,9 @@ describe('scheduled-event-handler', () => {
expect(event.data.reportDate).toBe('2024-01-14');
expect(event.specversion).toBe('1.0');
expect(event.id).toBeDefined();
expect(event.plane).toBe('data');
expect(event.source).toBe(
'/nhs/england/notify/production/primary/data-plane/digitalletters/reporting',
'/nhs/england/notify/production/primary/digitalletters/reporting',
);
expect(event.subject).toBe('customer/test-sender-123');
expect(event.type).toBe(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ export const createHandler = ({
},
specversion: '1.0',
id: randomUUID(),
plane: 'data',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/reporting', // CCM-13892
'/nhs/england/notify/production/primary/digitalletters/reporting', // CCM-13892
subject: `customer/${sender.senderId}`,
type: 'uk.nhs.notify.digital.letters.reporting.generate.report.v1',
time: new Date().toISOString(),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def create_valid_sqs_record(sender_id=SENDER_ID, report_uri=REPORT_URI):
'detail': {
'id': '6f1c2a53-3d54-4a0a-9a0b-0e9ae2d4c111',
'specversion': '1.0',
'source': '/nhs/england/notify/development/primary/data-plane/digitalletters/reporting',
'source': '/nhs/england/notify/development/primary/digitalletters/reporting',
'subject': 'customer/920fca11-596a-4eca-9c47-99f624614658',
'type': 'uk.nhs.notify.digital.letters.reporting.report.generated.v1',
'time': '2026-02-03T10:00:00Z',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ def __init__(self, **kwargs):

environment = 'development'
deployment = 'primary'
plane = 'data-plane'
self.__cloud_event_source = f'/nhs/england/notify/{environment}/{deployment}/{plane}/digitalletters/reporting'
self.__cloud_event_source = f'/nhs/england/notify/{environment}/{deployment}/digitalletters/reporting'

def _parse_and_validate_event(self, sqs_record) -> ReportGenerated:
"""Extract report generated data from SQS record"""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ describe('createHandler', () => {
const itemEnqueuedEvent: ItemEnqueued = {
...messageDownloadedEvent,
id: '550e8400-e29b-41d4-a716-446655440001',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/queue',
source: '/nhs/england/notify/production/primary/digitalletters/queue',
type: 'uk.nhs.notify.digital.letters.queue.item.enqueued.v1',
time: '2023-06-20T12:00:00.250Z',
recordedtime: '2023-06-20T12:00:00.250Z',
Expand Down
4 changes: 2 additions & 2 deletions lambdas/ttl-create-lambda/src/__tests__/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { MESHInboxMessageDownloaded } from 'digital-letters-events';
export const messageDownloadedEvent: MESHInboxMessageDownloaded = {
id: '550e8400-e29b-41d4-a716-446655440001',
specversion: '1.0',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/mesh',
source: '/nhs/england/notify/production/primary/digitalletters/mesh',
subject:
'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/769acdd4-6a47-496f-999f-76a6fd2c3959',
plane: 'data',
type: 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1',
time: '2023-06-20T12:00:00Z',
recordedtime: '2023-06-20T12:00:00.250Z',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,12 @@ const mockEvent: DynamoDBStreamEvent = {
id: { S: '550e8400-e29b-41d4-a716-446655440001' },
specversion: { S: '1.0' },
source: {
S: '/nhs/england/notify/production/primary/data-plane/digitalletters/mesh',
S: '/nhs/england/notify/production/primary/digitalletters/mesh',
},
subject: {
S: 'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/769acdd4-6a47-496f-999f-76a6fd2c3959',
},
plane: { S: 'data' },
type: {
S: 'uk.nhs.notify.digital.letters.mesh.inbox.message.downloaded.v1',
},
Expand Down Expand Up @@ -108,8 +109,7 @@ describe('createHandler', () => {
[
expect.objectContaining({
specversion: '1.0',
source:
'/nhs/england/notify/production/primary/data-plane/digitalletters/queue',
source: '/nhs/england/notify/production/primary/digitalletters/queue',
subject:
'customer/920fca11-596a-4eca-9c47-99f624614658/recipient/769acdd4-6a47-496f-999f-76a6fd2c3959',
type: 'uk.nhs.notify.digital.letters.queue.item.dequeued.v1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ properties:
pattern: ^uk\.nhs\.notify\.digital\.letters\.eventbus\.[a-z0-9]+(?:\.[a-z0-9]+)*\.v[0-9]+$
source:
type: string
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/(data-plane|control-plane)/digitalletters/eventbus
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/digitalletters/eventbus
minLength: 40
format: uri-reference
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ properties:
pattern: ^uk\.nhs\.notify\.digital\.letters\.fhir\.[a-z0-9]+(?:\.[a-z0-9]+)*\.v[0-9]+$
source:
type: string
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/(data-plane|control-plane)/digitalletters/fhir
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/digitalletters/fhir
minLength: 40
format: uri-reference
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ properties:
pattern: ^uk\.nhs\.notify\.digital\.letters\.letter\.[a-z0-9]+(?:\.[a-z0-9]+)*\.v[0-9]+$
source:
type: string
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/(data-plane|control-plane)/digitalletters/letter
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/digitalletters/letter
minLength: 40
format: uri-reference
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ properties:
pattern: ^uk\.nhs\.notify\.digital\.letters\.mesh\.[a-z0-9]+(?:\.[a-z0-9]+)*\.v[0-9]+$
source:
type: string
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/(data-plane|control-plane)/digitalletters/mesh
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/digitalletters/mesh
minLength: 40
format: uri-reference
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ properties:
pattern: ^uk\.nhs\.notify\.digital\.letters\.messages\.[a-z0-9]+(?:\.[a-z0-9]+)*\.v[0-9]+$
source:
type: string
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/(data-plane|control-plane)/digitalletters/messages
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/digitalletters/messages
minLength: 40
format: uri-reference
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ properties:
pattern: ^uk\.nhs\.notify\.digital\.letters\.pdm\.[a-z0-9]+(?:\.[a-z0-9]+)*\.v[0-9]+$
source:
type: string
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/(data-plane|control-plane)/digitalletters/pdm
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/digitalletters/pdm
minLength: 40
format: uri-reference
Loading
Loading