Skip to content

CCM14615 Unit test quickening#249

Draft
Ian-Hodges wants to merge 10 commits intomainfrom
feature/CCM-14615_unit-test-quickening
Draft

CCM14615 Unit test quickening#249
Ian-Hodges wants to merge 10 commits intomainfrom
feature/CCM-14615_unit-test-quickening

Conversation

@Ian-Hodges
Copy link
Copy Markdown
Contributor

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Ian-Hodges Ian-Hodges added the skip-trivy-package Skip the Trivy Package Scan label Mar 20, 2026
@Ian-Hodges Ian-Hodges changed the title Feature/ccm 14615 unit test quickening CCM14615 Unit test quickening Mar 23, 2026
@Ian-Hodges Ian-Hodges force-pushed the feature/CCM-14615_unit-test-quickening branch from 066c843 to c47ac23 Compare March 23, 2026 13:33
output/digital-letters/
src/digital-letters-events/types/
src/digital-letters-events/validators/
src/digital-letters-events/digital_letters_events/models/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose once we merge https://github.com/NHSDigital/nhs-notify-digital-letters/pull/254/changes then we need to add also guard-functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-trivy-package Skip the Trivy Package Scan

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants