CCM-15297: Prevent MeshDownloader from publishing duplicate events#243
Open
lapenna-bjss wants to merge 11 commits intomainfrom
Open
CCM-15297: Prevent MeshDownloader from publishing duplicate events#243lapenna-bjss wants to merge 11 commits intomainfrom
lapenna-bjss wants to merge 11 commits intomainfrom
Conversation
…m_publishing_duplicate_events
…m_publishing_duplicate_events
sidnhs
previously approved these changes
Mar 25, 2026
Contributor
aidenvaines-cgi
left a comment
There was a problem hiding this comment.
you only need to do that if concatinating strings etc
infrastructure/terraform/components/dl/module_lambda_mesh_download.tf
Outdated
Show resolved
Hide resolved
infrastructure/terraform/components/dl/module_lambda_mesh_download.tf
Outdated
Show resolved
Hide resolved
simonlabarere
previously approved these changes
Mar 31, 2026
simonlabarere
previously approved these changes
Mar 31, 2026
…m_publishing_duplicate_events
nhsd-angel-pastor
approved these changes
Mar 31, 2026
Contributor
nhsd-angel-pastor
left a comment
There was a problem hiding this comment.
Jus wondering whether we want to add in the PII bucket the if-none-header match restriction to enforce putObject requests to have the header (https://docs.aws.amazon.com/AmazonS3/latest/userguide/conditional-writes-enforce.html)
simonlabarere
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures the MESH Downloader does not process or publish a message with the same meshMessageId more than once.
Context
Duplicate messages can occur internally due to retries or when a message is re-polled before it is removed from the MESH inbox.
Key changes
Duplicate message is not published, but is acknowledged:


Duplicate metric:

Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.