Skip to content

Perf/concurrency#85

Merged
dylanlee merged 28 commits into
mainfrom
perf/concurrency
Apr 23, 2026
Merged

Perf/concurrency#85
dylanlee merged 28 commits into
mainfrom
perf/concurrency

Conversation

@dylanlee
Copy link
Copy Markdown

@dylanlee dylanlee commented Apr 22, 2026

See commit messages for work done.

Work involves changes necessary to stop nginx from timing out and to increase API concurrency. Minor changes to make PET return an empty list on parameter_metadata and a schema change that allows for the NHD table to be added to the icefabric tables.

starlette farms out handlers defined using def to a threadpool. This is
what we want since our code isn't async except for the rise endpoint
default nginx timeout of 60s was causing 504 responses even though the
fastapi app was still working
@dylanlee dylanlee requested a review from danielcumpton April 22, 2026 01:28
Comment thread app/routers/hydrofabric/router.py Fixed
Comment thread app/routers/hydrofabric/router.py Fixed
@danielcumpton
Copy link
Copy Markdown

danielcumpton commented Apr 23, 2026

Running the parameter metadata endpoint with PET returns and empty JSON as expected. I ran all of the CONUS gages that had failed listed in NGWPC-10302. 01105933 and 02310525 look like they are subset correctly.
06605850, 06607200 and 08189520 are capturing too upstream features that are not part of the basin where the gage is located.

@dylanlee dylanlee merged commit 0193683 into main Apr 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants