Skip to content

Implement reset_time message (NGWPC-9618)#9

Merged
idtodd merged 2 commits into
developmentfrom
idt-reset-time
Mar 13, 2026
Merged

Implement reset_time message (NGWPC-9618)#9
idtodd merged 2 commits into
developmentfrom
idt-reset-time

Conversation

@idtodd
Copy link
Copy Markdown

@idtodd idtodd commented Jan 27, 2026

Hindcasting requires resetting a BMI to time 0 after loading a state. This implements the message "reset_time" for signaling to the BMI that it should set its time to 0.

Changes

  • SetValue includes an option for "reset_time" that sets the model's time and timesteps to 0. These are sufficient for resetting time for this BMI.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@idtodd idtodd requested a review from sivasankkar January 27, 2026 14:29
@idtodd idtodd self-assigned this Jan 27, 2026
@idtodd idtodd changed the title Implement reset_time message Implement reset_time message (NGWPC-9618) Jan 27, 2026
Copy link
Copy Markdown

@cmaynard-ngwpc cmaynard-ngwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested in AWS Workspace.

@idtodd idtodd merged commit be9146a into development Mar 13, 2026
@idtodd idtodd deleted the idt-reset-time branch March 13, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants