Skip to content

Add NWM Ponded Depth (NGWPC-9175)#6

Merged
idtodd merged 2 commits into
developmentfrom
idt-nwm-ponded-depth-output
Jan 13, 2026
Merged

Add NWM Ponded Depth (NGWPC-9175)#6
idtodd merged 2 commits into
developmentfrom
idt-nwm-ponded-depth-output

Conversation

@idtodd
Copy link
Copy Markdown

@idtodd idtodd commented Dec 15, 2025

This change adds as a CFE NWM_PONDED_DEPTH calculation to LASAM. The output variable name is lowercase for LASAM for consistency with LASAM's variables and to prevent multiple BMIs from sharing the same output variable names (something that can cause problems in Multi_Bmi_Formulations.

CFE calculates the ponded runoff as the sum of the giuh runoff queue during it's Update method. LASAM will now replicate this method.

Additions

  • bmi_unit_conversion::volrunoff_guih_ponded_m double value added for storing the calculation.
  • BmiLGAR::Update computes the ponded value and assigns it.

Removals

Changes

  • BmiLGAR::serialize accounts for this value.
  • BmiLGAR::output_var_names has its size increased and "nwm_ponded_depth" added.
  • BmiLGAR variables methods GetVarGrid, GetVarUnits, GetVarLocation, and GetValuePtr updated to look for "nwm_ponded_depth".

Testing

Screenshots

Notes

  • The default value of bmi_unit_conversion::volrunoff_guih_ponded_m is not defined in creation or initialization from config file, just like all other bmi_unit_conversion values.

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@idtodd idtodd requested a review from sivasankkar January 13, 2026 14:18
Copy link
Copy Markdown

@sivasankkar sivasankkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are good to go to include NWM ponded depth variable in LASAM.

@idtodd idtodd merged commit 764dc82 into development Jan 13, 2026
@idtodd idtodd deleted the idt-nwm-ponded-depth-output branch January 13, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants