Add NWM Ponded Depth (NGWPC-9175)#6
Merged
Conversation
sivasankkar
approved these changes
Jan 13, 2026
sivasankkar
left a comment
There was a problem hiding this comment.
All changes are good to go to include NWM ponded depth variable in LASAM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds as a CFE
NWM_PONDED_DEPTHcalculation to LASAM. The output variable name is lowercase for LASAM for consistency with LASAM's variables and to prevent multiple BMIs from sharing the same output variable names (something that can cause problems inMulti_Bmi_Formulations.CFE calculates the ponded runoff as the sum of the giuh runoff queue during it's
Updatemethod. LASAM will now replicate this method.Additions
bmi_unit_conversion::volrunoff_guih_ponded_mdoublevalue added for storing the calculation.BmiLGAR::Updatecomputes the ponded value and assigns it.Removals
Changes
BmiLGAR::serializeaccounts for this value.BmiLGAR::output_var_nameshas its size increased and"nwm_ponded_depth"added.BmiLGARvariables methodsGetVarGrid,GetVarUnits,GetVarLocation, andGetValuePtrupdated to look for"nwm_ponded_depth".Testing
Screenshots
Notes
bmi_unit_conversion::volrunoff_guih_ponded_mis not defined in creation or initialization from config file, just like all otherbmi_unit_conversionvalues.Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other