check for soil_type value#14
Merged
Merged
Conversation
cmaynard-ngwpc
left a comment
cmaynard-ngwpc
left a comment
There was a problem hiding this comment.
Address comments made in the updates
cmaynard-ngwpc
approved these changes
Apr 21, 2026
cmaynard-ngwpc
left a comment
cmaynard-ngwpc
left a comment
There was a problem hiding this comment.
Thanks for making the updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
https://jira.nextgenwaterprediction.com/browse/NGWPC-9151
This update is not the solution of the problem as that needs to happen in MSMW who creates the LASAM BMI Input config file.
Here we just do checking and exit earlier if wrong values are in the config.
Please see following doc for details:
https://confluence.nextgenwaterprediction.com/spaces/NGWPC/pages/94961741/NGEN+Bug+Investigation+Issues#NGENBugInvestigationIssues-LASAMInitializationFailure%E2%80%93RootCauseAnalysis&FixPlan
I have tested with running the formulation 100 times (after manually updating the input files and did not see the error in the story.