Skip to content

Use nwm-ewts repository CPP library#12

Merged
cmaynard-ngwpc merged 1 commit into
developmentfrom
cmaynard_use_ewts_libray
Mar 25, 2026
Merged

Use nwm-ewts repository CPP library#12
cmaynard-ngwpc merged 1 commit into
developmentfrom
cmaynard_use_ewts_libray

Conversation

@cmaynard-ngwpc
Copy link
Copy Markdown

@cmaynard-ngwpc cmaynard-ngwpc commented Mar 18, 2026

The Error, Warning, and Trapping System has been refactored into a single repository with runtime libraries for CPP.
This update removes the previous logger code and uses the ewts CPP library.

Additions

  • Include the ewts appropriate header files in logger.cpp

Removals

  • Deprecated code from logger.hpp
  • Deprecated logger.cpp file

Changes

  • CMakeList.ext updated to use C++17, remove building the deprecatedlogger and use the EWTS cpp library
  • Logger header ifdef guard name to be module specific

Testing

  1. Local testing with ngen and PW testing on DEV2 cluster

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@cmaynard-ngwpc cmaynard-ngwpc changed the title Updates to use the nwm-ewts library Use nwm-ewts repository CPP library Mar 18, 2026
@cmaynard-ngwpc cmaynard-ngwpc merged commit e3411b3 into development Mar 25, 2026
1 check failed
@cmaynard-ngwpc cmaynard-ngwpc deleted the cmaynard_use_ewts_libray branch March 25, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant