Convert assert calls to error logs (NGWPC-7474)#1
Merged
Conversation
cmaynard-ngwpc
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Built fine and the code looks good. Note you could have taken advantage of the overloaded Log method using varargs, LOG(LogLevel messageLevel, const char* message, ...);, instead of creating a std:stringstream to build each of the error messages.
Tested running ngen with lasam and noah-owp-modular with 2 different gages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert assert calls that will give unhelpful error messages to error messages that will be logged through the Logger followed by exception throws.