Repository navigation
fix(forms): Add Contact closes on save, New Template keeps its error (QA FORM-01, FORM-06) - #35
Merged
Merged
Conversation
…(QA sweep FORM-01) ContactModal read fetcherOk inside onSubmit, i.e. the previous submission's result, so a first successful save never closed the dialog. Close in an effect on the fetcher's busy -> idle transition with ok:true; the modal stays mounted so an earlier ok:true is still in fetcher.data and the value alone is not a trigger. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…swers (QA sweep FORM-06) handleCreate closed the dialog and cleared the name on click, so the API's refusal of an over-long name rendered into a dialog that was already gone and the click looked like a no-op. Stay open: success navigates to the editor, failure shows the error in place. maxLength=100 on the field matches the API. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ContactModalread the previous submission's result insideonSubmit, so a first successful save never closed the dialog. It now closes on the fetcher's busy -> idle transition withok:true.maxLength={100}matches the API.One commit per finding, plus the fork-log rows.
Checked
git fetch upstream(435b24ec); keyword and file greps.793a4161touchedContactModal(busy latch) and left the stale read; no upstream fix for either.npm run lint:gates-full80 of 80 (afterlint:eol --fix); pre-commit passed on all three commits.Not done
No "Contact added" toast and no character counter (new strings in both locales); see the fork-log rows. Not seen in the pane.
🤖 Generated with Claude Code