Repository navigation
fix(setup): operator notes sit behind a closed disclosure (QA sweep ONB-02) - #33
Merged
Merged
Conversation
…the form (QA sweep ONB-02) A brand-new admin's first screen ended with "only whoever operates this deployment can publish them, from the command line: npm run agent-terms:publish", about a feature (agents) they have not met, and the setup-code hint spoke in Cloudflare dashboard paths. Both notes now live in one `<details>` that is closed on first paint, summary "For whoever deployed this: the setup code and agent sign-up" (en and es-419). The setup-code field keeps "Required (at least 6 characters)." and a short pointer at the note. The summary names what is inside, so F74's reason for the note (an operator who only runs this wizard never sees the publish step) still has an on-page answer, and nothing in the form waits on it. Tests: `setup.test.tsx` now asserts the arrangement (closed `<details>` holding the agent-terms note, the command and the secret steps; the field hint outside it) and is red against the previous page; the "does not block finishing setup" case is unchanged. fork-log row added, including the conflict to expect when `fa7e6aac` is cherry-picked. Chrome: /setup — closed disclosure under the form, setup-code hint points at it, opens to both notes, dark and light theme, no horizontal overflow at 375 px Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/setupended with CLI language about a feature (agents) a brand-new admin has not met: "only whoever operates this deployment can publish them, from the command line:npm run agent-terms:publish", and the setup-code hint spoke in Cloudflare dashboard paths (QA sweep finding ONB-02, Minor).Both notes now sit in one
<details>, closed on first paint, summary "For whoever deployed this: the setup code and agent sign-up" (en and es-419). The setup-code field keeps "Required (at least 6 characters)." plus a one-line pointer at the note. Nothing in the form waits on it.Why this shape
git fetch upstream(435b24ec), subject greps andgit log main..upstream/mainonapp/routes/setup.tsxfind onlyfa7e6aac(submit latch, reserved error space), which does not touch the notes. Recorded as a fork deviation indocs/develop/fork-log.md, with the conflict to expect whenfa7e6aacis cherry-picked.Checked
app/routes/setup.test.tsxasserts the arrangement and is red against the previous page (2 of 3 fail), green with the change; the "does not block finishing setup" case is unchanged.lint:gates27 of 27,lint:i18n,lint:i18n-catalog(es-419 5458/5458),lint:i18n-literals,lint:i18n-glossary, eslint 0 errors on both files, pre-commit and pre-push hooks passed./setupshows the closed disclosure, the hint points at it, it opens to both notes; dark and light theme; no horizontal overflow at 375 px (summary wraps to two lines).Ceilings
🤖 Generated with Claude Code