Skip to content

fix(setup): operator notes sit behind a closed disclosure (QA sweep ONB-02) - #33

Merged
NCHILLC merged 1 commit into
mainfrom
fix/qa-onb-02-setup-operator-notes
Oct 13, 2026
Merged

NCHILLC merged 1 commit into
mainfrom
fix/qa-onb-02-setup-operator-notes

Conversation

@NCHILLC

@NCHILLC NCHILLC commented Oct 13, 2026

Copy link
Copy Markdown
Owner

What

/setup ended with CLI language about a feature (agents) a brand-new admin has not met: "only whoever operates this deployment can publish them, from the command line: npm run agent-terms:publish", and the setup-code hint spoke in Cloudflare dashboard paths (QA sweep finding ONB-02, Minor).

Both notes now sit in one <details>, closed on first paint, summary "For whoever deployed this: the setup code and agent sign-up" (en and es-419). The setup-code field keeps "Required (at least 6 characters)." plus a one-line pointer at the note. Nothing in the form waits on it.

Why this shape

  • The summary names what is inside, so F74's reason for the note (an operator who only runs this wizard never sees the publish step) still has an on-page answer.
  • Upstream has no fix: git fetch upstream (435b24ec), subject greps and git log main..upstream/main on app/routes/setup.tsx find only fa7e6aac (submit latch, reserved error space), which does not touch the notes. Recorded as a fork deviation in docs/develop/fork-log.md, with the conflict to expect when fa7e6aac is cherry-picked.

Checked

  • app/routes/setup.test.tsx asserts the arrangement and is red against the previous page (2 of 3 fail), green with the change; the "does not block finishing setup" case is unchanged.
  • lint:gates 27 of 27, lint:i18n, lint:i18n-catalog (es-419 5458/5458), lint:i18n-literals, lint:i18n-glossary, eslint 0 errors on both files, pre-commit and pre-push hooks passed.
  • Browser pane on a build against an empty D1: /setup shows the closed disclosure, the hint points at it, it opens to both notes; dark and light theme; no horizontal overflow at 375 px (summary wraps to two lines).

Ceilings

  • An operator with no setup code needs one click to find where to add it: the hint says so but does not carry the steps.
  • The disclosure does not remember being opened.

🤖 Generated with Claude Code

…the form (QA sweep ONB-02)

A brand-new admin's first screen ended with "only whoever operates this
deployment can publish them, from the command line: npm run
agent-terms:publish", about a feature (agents) they have not met, and the
setup-code hint spoke in Cloudflare dashboard paths.

Both notes now live in one `<details>` that is closed on first paint, summary
"For whoever deployed this: the setup code and agent sign-up" (en and es-419).
The setup-code field keeps "Required (at least 6 characters)." and a short
pointer at the note. The summary names what is inside, so F74's reason for the
note (an operator who only runs this wizard never sees the publish step) still
has an on-page answer, and nothing in the form waits on it.

Tests: `setup.test.tsx` now asserts the arrangement (closed `<details>` holding
the agent-terms note, the command and the secret steps; the field hint outside
it) and is red against the previous page; the "does not block finishing setup"
case is unchanged. fork-log row added, including the conflict to expect when
`fa7e6aac` is cherry-picked.

Chrome: /setup — closed disclosure under the form, setup-code hint points at it, opens to both notes, dark and light theme, no horizontal overflow at 375 px

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@NCHILLC
NCHILLC merged commit a44ca4a into main Oct 13, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant