Repository navigation
ci(gate): run verify on pushes to main, not only pull requests - #1
Merged
Merged
Conversation
The workflow triggered on `pull_request` alone, so a commit that never opened a PR was never gated. Forty-seven commits reached this fork's main that way and `verify` has run against none of them. Branch protection cannot require a check it has never seen, so the empty required-checks box was a symptom of the same gap: no run, no name. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CLAUDE.md claimed `verify` was the authoritative gate and, two paragraphs later, that pushing runs no CI at all. Both are now wrong in different directions, and a session reading either one acts on it. CI runs as of the trigger change in this branch. It still cannot block a merge: branch protection and rulesets are unenforced on a private repo under GitHub Free, so the `verify` ruleset exists and is inert until the org moves to Team. Pre-commit stays the only gate that stops anything. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.ymltriggered onpull_requestalone, so a commit that never opened a PR was never gated. Forty-seven commits reached this fork'smainthat way andverifyhas run against none of them. Addspush: branches: [main]alongside the existing triggers.This PR is also the mechanism for the second half of the problem: branch protection cannot require a status check it has never seen, so the empty required-checks box on
mainwas a symptom of the same gap. Once this PR's run completes,verifybecomes a name GitHub knows and can be added as a required check.Type of change
Test plan
verifyreports on this PR — that result is the testNotes
mainand PRs both run, roughly doubling billed runner-minutes on merges.concurrencywithcancel-in-progressstill de-duplicates superseded runs on the same ref.Follow-ups (not in this PR)
verifyunder Settings → Branches → branch protection once this run finishes.mainis rejected for carrying no passing check.uses:acrossci.yml,codeql.ymlandrelease-please.ymlis pinned to a SHA — all ~30 are currently tag-pinned and would fail immediately.🤖 Generated with Claude Code