Adding some information on Standard Names for dimensions in metadata files#80
Adding some information on Standard Names for dimensions in metadata files#80
Conversation
mkavulich
requested review from
climbfuji,
grantfirl and
ligiabernardet
as code owners
mkavulich
force-pushed
the
add_dimensions_info
branch
from
c66d568 to
ac52226
Compare
| [dim_name]_begin:[dim_name]_end ==> 1:[dim_name]_loop_extent | ||
| [dim_name]_begin:[dim_name]_end ==> 1:[dim_name]_dimension |
There was a problem hiding this comment.
I know what you mean (because I wrote ccpp-prebuild), but for most people this will be confusing and scary. We need to explain that the left side (slices of the entire array allocated by the host model) in the CCPP run phase are sent to the CCPP physics scheme for parallel processing using OpenMP threading, and that schemes require the horizontal "dimension" for the current call to run from 1 to the length of the slice. I hope you can explain that better; some of it may already be explained in the next section (It is important to understand the difference between horizontal_dimension vs. horizontal_loop_extent), in which case we should refer to that section.
There was a problem hiding this comment.
Much of this text was pulled out of the "dimensions" comment of the Standard Names, since it shouldn't really be documented there anymore. But I admit I do not know much about how CCPP handles parallelization decomposition, except from what I've read in the documentation. I have tried to rephrase it better to the best of my understanding of how CCPP works, please let me know if the current version makes more sense or if you think it needs more work.
| but not in xxx_run routines. Currently, the only dimension which supports all | ||
| six dimension types is horizontal_dimension. |
There was a problem hiding this comment.
I don't really understand what you mean with the last sentence, but I don't it's correct and it should probably be removed.
There was a problem hiding this comment.
This was another phrase directly from the comments I pulled out of the Standard Names. I think the intention was to indicate that OpenMP parallelism is only broken down along the horizontal dimension, not other dimensions. Is this not correct?
2 participants
As part of the ESM Standard Names reorganization (PR incoming), I noticed a lot of CCPP-specific information about dimensions was stored there, that should more properly be located in the CCPP tech doc. This PR adds that information.