Skip to content

Add sm2a test for veda deploy #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amarouane-ABDELHAK wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Add sm2a test for veda deploy #369

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
120a39b
Add veda SM2A test for VEDA deploy
amarouane-ABDELHAK May 12, 2025
3653c77
Switch working directory for test
amarouane-ABDELHAK May 12, 2025
9af938e
Add pip cache for uv
amarouane-ABDELHAK May 12, 2025
15a353e
activate uv venv
amarouane-ABDELHAK May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/actions/terraform-deploy-sm2a/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,23 +28,33 @@ runs:

steps:
- name: Set up Python
uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
uses: astral-sh/setup-uv@v5
with:
python-version: "3.11"
cache: "pip"


- name: Setup Terraform
uses: hashicorp/setup-terraform@ed3a0531877aca392eb870f440d9ae7aba83a6bd #v1.4.0
with:
terraform_version: 1.3.10

- name: Test 🧪
working-directory: "veda-data-airflow"
shell: bash
run: |
uv sync --all-groups
export AIRFLOW_HOME=/tmp
uv run airflow db migrate
uv run pytest

- name: Deploy
working-directory: ${{ inputs.dir }}
shell: bash
env:
AWS_DEFAULT_REGION: ${{ inputs.aws-region }}
AWS_REGION: ${{ inputs.aws-region }}
run: |
# Activate uv venv
source ../.venv/bin/activate
Copy link
Copy Markdown
Contributor

@anayeaye anayeaye May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this venv already exist on the runner?

Copy link
Copy Markdown
Contributor Author

@amarouane-ABDELHAK amarouane-ABDELHAK May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will be created during uv setup

Copy link
Copy Markdown
Contributor

@anayeaye anayeaye May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. This uv stuff is new to me. Is there reason to deactivate at the end of the job in case another job follows on the same runner? Informational question only, not change request!

Copy link
Copy Markdown
Contributor Author

@amarouane-ABDELHAK amarouane-ABDELHAK May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It automatically deactivates when the step is complete. You'll need to manually activate it for the next step. It's an annoying thing of GitHub workflows but in this use case it actually turns out to be a useful feature, lol the irony.

Copy link
Copy Markdown
Contributor

@ividito ividito May 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv run make ... should also work here, but this is more explicit anyway

make sm2a-deploy ENV_FILE=${{ inputs.env-file }} SECRET_NAME=${{ inputs.env_aws_secret_name }}

- name: Output workflows API endpoint
Expand Down