Add item ordering in record value mapper to allow ordering of activity/scheduling goal parameters#1738
Merged
Merged
Conversation
adrienmaillard
had a problem deploying
to
e2e-test
GitHub Actions
Failure
adrienmaillard
force-pushed
the
feature/ordering-scheduling-goal-params
branch
from
6490e82 to
25be4e3
Compare
adrienmaillard
had a problem deploying
to
e2e-test
GitHub Actions
Failure
adrienmaillard
had a problem deploying
to
e2e-test
GitHub Actions
Failure
adrienmaillard
force-pushed
the
feature/ordering-scheduling-goal-params
branch
from
25be4e3 to
af92000
Compare
adrienmaillard
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
|
mattdailis
approved these changes
Jan 8, 2026
Collaborator
mattdailis
left a comment
mattdailis
left a comment
There was a problem hiding this comment.
Looks good to me based on reading the code and manual testing
Collaborator
|
Tested with Matt, merging this + NASA-AMMOS/plandev-ui#1773 - Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Metadata containing item order is now attached to every
RecordValueMapperso it can be used by the UI to display parameters in the order it has been defined in the scheduling procedures.Changes in the UI are on branch https://github.com/NASA-AMMOS/aerie-ui/tree/ordering-scheduling-goal-params
Verification
With tests in
RecordValueMapperTests. I also performed an end to end test with the UI code and activities/procedural goals. For ordering at the top level, I could use procedural goals but because of issue #1737 that I have found while developing, I had to test the nested ordering with activity parameters on the bananation model.Documentation
Docs about parameters of mission models/procedural goals and constraints will have to mention that the way of ordering parameters is to go through records and use the default record value mapper. Custom value mappers for records will not produce the ordering.
Future work
None.