Correctly raise exceptions for HTTP errors - #15
Open
leccelecce wants to merge 1 commit into
Open
Conversation
danielpetrovic
added a commit
to danielpetrovic/pykefcontrol
that referenced
this pull request
Apr 24, 2026
- Add "LSXII" to _POST_MODELS so fw3.0 setData calls use POST instead of GET (which returns 405 on fw3.0). Supersedes PR N0ciple#16. - Add "LSX2" → "LSXII" to _MODEL_ALIASES so older firmware or API responses using the legacy name still resolve correctly - Add raise_for_status() before every response.json() call so HTTP errors surface instead of being silently swallowed, based on leccelecce's work in N0ciple#15 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
danielpetrovic
added a commit
to danielpetrovic/pykefcontrol
that referenced
this pull request
Apr 26, 2026
- Add "LSXII" to _POST_MODELS so fw3.0 setData calls use POST instead of GET (which returns 405 on fw3.0). Supersedes PR N0ciple#16. - Add "LSX2" → "LSXII" to _MODEL_ALIASES so older firmware or API responses using the legacy name still resolve correctly - Add raise_for_status() before every response.json() call so HTTP errors surface instead of being silently swallowed, based on leccelecce's work in N0ciple#15 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
danielpetrovic
added a commit
to danielpetrovic/pykefcontrol
that referenced
this pull request
May 4, 2026
- Add "LSXII" to _POST_MODELS so fw3.0 setData calls use POST instead of GET (which returns 405 on fw3.0). Supersedes PR N0ciple#16. - Add "LSX2" → "LSXII" to _MODEL_ALIASES so older firmware or API responses using the legacy name still resolve correctly - Add raise_for_status() before every response.json() call so HTTP errors surface instead of being silently swallowed, based on leccelecce's work in N0ciple#15 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the library just blindly calls the HTTP library, it doesn't do anything with errors at all.
Discovered this because I was wondering why hass-kef-connector doesn't raise any error in the HASS UI or system logs that I can see, even though I'm trying to use old pykefcontrol against latest LSX II LT firmware.
Should be using
response.raise_for_status()to detect any non HTTP 2xx/3xx response code and throwing exception which upstream users can deal with.