fix(web): constrain preparing shell to the primary content rail - #1751
Merged
Merged
Conversation
The preparing view stretched to full pane width while the composer and chat content stay on PRIMARY_CONTENT_RAIL_CLASS, so the startup card rendered wider than the composer on wide panes.
…rail-width # Conflicts: # apps/web/src/features/conversation/messages/chat-view/ChatViewSurface.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The thread preparing view stretched to the full chat pane width while the composer and chat content stay centered on the shared content rail (
PRIMARY_CONTENT_RAIL_CLASS, max-width 96rem). On wide panes the startup card rendered noticeably wider than the composer.The preparing shell now wraps its content in the same
PRIMARY_CONTENT_RAIL_CLASSused byComposerandMessageList, so the startup card, queued-message bubble, and composer share one rail and identical left/right edges.Verified on the live Electron surface at 2400px viewport width. Before video shows the card spanning the full pane; after video shows it aligned with the composer rail.
Why
End users see a jarring width jump when a thread starts: the preparing view is wider than the chat content that replaces it. The view is meant to be as wide as the composer, not wider.
UI Changes
startup-card-width-before.mp4(attached). Card spans the full pane width.startup-card-width-after.mp4(attached). Card aligns with the composer and chat content rail.Config Changes
None
Review Notes
bun run lint apps/web/src/features/conversation/messages/chat-view/ChatViewSurface.tsxclean.bun run --cwd apps/web typecheckclean.bun run --cwd apps/web test -- src/features/conversation/messages/__tests__/ChatView.test.tsx49/49 passed.startup-card-width-before.mp4
startup-card-width-after.mp4
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.