Repository navigation
Graceful random restarts in test_simulated_load_reconfig_restarts - #28255
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mystenmark
deployed
to
sui-typescript-aws-kms-test-env
October 8, 2026 17:10 — with 
GitHub Actions
Active
GitHub Actions
Active
mystenmark
force-pushed
the
mlogan/graceful-restart-simtest
branch
4 times, most recently
from
October 22, 2026 23:50
3ad7f0d to
e178870
Compare
mystenmark
marked this pull request as ready for review
October 23, 2026 03:55
alex-mysten
approved these changes
Oct 23, 2026
RandomNodeRestarter can stop validators the way SIGTERM does, using mysten-sim's graceful shutdown (runtime-drop model): async tasks keep running briefly while spawn_blocking returns cancelled handles. The restarts test uses it, restarts more often, and raises the rate of conflicting transactions. Bumps mysten-sim (graceful shutdown, blocking latency) and anemo (resolve no longer panics on cancellation).
mystenmark
force-pushed
the
mlogan/graceful-restart-simtest
branch
from
October 27, 2026 17:38
e178870 to
de59aaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simtests only ever hard-killed nodes, which models SIGKILL. A production node stopped by SIGTERM drops its tokio runtime instead: async tasks keep running briefly while
spawn_blockingreturns cancelled handles. Code that reads a cancelled task as a normal result can persist wrong state in that window, and no test exercised it. C3-A02 (#28243) is one such bug.RandomNodeRestarter::with_graceful_shutdownstops validators with mysten-sim's runtime-drop model, andtest_simulated_load_reconfig_restartsnow uses it, restarts more often (every 2-6 s), and raises the rate of conflicting transactions so the commit finalizer's indirect finalization runs. The mysten-sim bump also gives blocking tasks sim-time latency in all simtests, so code must be correct whenspawn_blockingdoes not complete in the same instant.Pins mysten-sim to its main head (MystenLabs/mysten-sim#80 plus the tokio 1.54.1 bump in #81) and anemo to the MystenLabs/anemo#76 merge commit. The test found the bugs fixed in #28252, #28253, and #28254, and it fails without them.
Test plan
With all dependencies: 500 of 500 seeds of
test_simulated_load_reconfig_restartspass. With #28243's finalizer fix reverted, the test hit the C3-A02 fork in 1 of 500 seeds, without any failpoint at the bug site.🤖 Generated with Claude Code
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.