define replacement for from and update deps#9
Merged
MystPi merged 1 commit intoMystPi:masterfrom Jul 5, 2025
bwireman:master
Merged
define replacement for from and update deps#9MystPi merged 1 commit intoMystPi:masterfrom bwireman:master
MystPi merged 1 commit intoMystPi:masterfrom
bwireman:master
Conversation
Contributor
|
The dependency on gleeunit should also become a dev-dependency maybe this could be done in this PR? |
inoas
approved these changes
Jul 5, 2025
| -define(is_lowercase_char(X), (X > 96 andalso X < 123)). | ||
| -define(is_underscore_char(X), (X == 95)). | ||
|
|
||
| from(X) -> |
Contributor
There was a problem hiding this comment.
Would it make sense to use https://github.com/gleam-lang/stdlib/blob/main/src/gleam_stdlib.erl#L49 aka function.identity from stdlib?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is a solution to https://github.com/MystPi/pprint/issues if you're open to it