fix(meetings): preserve recording end during processing - #68
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e18122376
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| # Freeze a successful Stop before recorder/provider draining can | ||
| # delay persistence of the state transition. | ||
| capture_ended_at = datetime.now(UTC) if command == "audioMeetingStop" else None |
There was a problem hiding this comment.
When audioMeetingPause succeeds but recorder.stop() subsequently fails, this leaves capture_ended_at as None; the terminal capture_failed transition then records endedAt only after live_transcriber.stop() finishes. A slow provider cleanup therefore still shifts the durable capture end past the actual native-audio stop for this pause-failure path. Capture the timestamp for a successful pause command as well (the ordinary paused transition will not persist it), so the failure transition can retain the true boundary.
Useful? React with 👍 / 👎.
1 participant
Meeting duration could grow from a four-hour Friday recording to nearly 60 hours when finalization was retried on Sunday. Processing transitions overwrote the capture end timestamp.
Preserve the first capture end through finalization, analysis, failures, restart recovery, and full retranscription. Capture successful native Stop/Pause time before recorder/provider cleanup so a failed Pause also retains the actual boundary. Normal Pause does not end the meeting. Clear the end only when recording actually resumes, and freeze stopped UI clocks including failure states. Prepare updater release 0.5.125.
Validation: 317 Meeting/backend tests and 10 frontend timing/playback tests passed during implementation. On current main, targeted capture-boundary and cleanup-failure regressions, frontend typechecks, focused frontend tests, repository-wide Ruff lint/format, and 39 release version/cache contract tests pass. GitHub full Python, frontend, Rust, and typecheck gates passed; the browser-start infrastructure timeout is retried separately without rerunning successful gates.