Add DefaultDllImportSearchPaths attribute to WindowsAppRuntime_EnsureIsLoaded method#10
Draft
Add DefaultDllImportSearchPaths attribute to WindowsAppRuntime_EnsureIsLoaded method#10
Conversation
…IsLoaded method Co-authored-by: MuyuanMS <116717757+MuyuanMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Missing DefaultDllImportSearchPaths attribute in WindowsAppRuntime_EnsureIsLoaded when WindowsAppSDKSelfContained is turned on
Add DefaultDllImportSearchPaths attribute to WindowsAppRuntime_EnsureIsLoaded method
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the code analysis warning CA5392 that occurs when
WindowsAppSDKSelfContainedand code analysis are turned on for a WinUI 3 project.Issue Details
When building a WinUI 3 project with both
WindowsAppSDKSelfContainedset to true and code analysis enabled, the build fails due to CA5392 warning:This happens because the DllImport declaration in
UndockedRegFreeWinRT-AutoInitializer.cswas missing the required attribute, which is considered a security risk due to potential DLL hijacking.Solution
Added the
DefaultDllImportSearchPathsattribute withDllImportSearchPath.SafeDirectoriesvalue to theWindowsAppRuntime_EnsureIsLoadedmethod:This value was chosen because:
DllImportSearchPath.ApplicationDirectoryFixes #9.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
microsoft.pkgs.visualstudio.comdotnet build WindowsAppRuntime.sln(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.