Testing#2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a73b1ef46
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ -z "$LASTN" ]; then N=1; else N=$((LASTN+1)); fi | ||
|
|
||
| NEW="$BASE-beta.$N" | ||
| NEW="$BASE-testing.$N" |
There was a problem hiding this comment.
With NEW now using -testing.N, this workflow relies on electron-builder to emit testing.yml, but I checked electron-builder.yml and its GitHub publish config still has no channel. The electron-builder docs for detectUpdateChannel say it “does not apply to github publishing,” and the release-channel docs warn that GitHub publishing must explicitly set channel; as written, npx electron-builder --win --publish always will keep uploading latest.yml while the new updater code looks for testing.yml, so beta installs will not discover these releases.
Useful? React with 👍 / 👎.
1 participant
No description provided.