Harden share audio, networking, and security - #2
Draft
Dahhrk wants to merge 6 commits into
Draft
Conversation
Keep computer sound on the share track while voice stays on the call. Windows process-loopback now passes stereo desktop audio through without a soft canceller, and the UI makes that split explicit.
Add ICE recovery and peer-left signaling, prefer isolated stereo share audio via AudioWorklet with an older-Windows endpoint fallback, remove hardcoded GIF keys, validate relayed signal payloads, ship helper unit tests, and stop tracking build junk.
Dahhrk
force-pushed
the
fix/screen-share-audio-loopback
branch
from
August 5, 2026 01:51
b08d291 to
c0b7583
Compare
… load. Prepare the computer-sound track before one renegotiate to avoid a second audio-only race, harden AudioWorklet loading, and improve endpoint-mode capture when call voice reference is available. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep isolated share capture and single-renegotiate attach, and fold in upstream wait-for-stable renegotiation plus Linux share cleanup fixes. Co-authored-by: Cursor <cursoragent@cursor.com>
Wait for stable signaling before claiming computer-sound success, probe Linux mic permission before PipeWire enumeration with generation-guarded sink teardown, and drop the Windows endpoint-loopback fallback in favor of video-only when process exclusion is unavailable. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep loopback hardening and video-only fallback; take master call-audio isolation, screen gesture guard, and 1.1.24 package metadata. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan