⚡ Bolt: [performance improvement] Pre-compute lookup map for KnowledgeGraph - #202
servathadi wants to merge 1 commit into
Conversation
- Initializes a ref `nodeMapRef` to hold the O(1) lookup map. - Populates the map in the same `useEffect` that initializes the canvas nodes. - Replaces the per-frame `new Map()` allocation inside the `simulate` requestAnimationFrame loop with `nodeMapRef.current`. - Prevents constant memory allocation/deallocation during the 60fps render loop, reducing jank and dropped frames. Co-authored-by: servathadi <116760885+servathadi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
💡 What: Replaced the per-frame
new Map()allocation and population inside theKnowledgeGraph'srequestAnimationFrameloop with a pre-computed map stored in auseRef.🎯 Why: In hot execution paths like a 60 FPS Canvas animation loop, instantiating new Map objects and iterating over the node array to populate them on every single frame causes significant memory allocation pressure. This continuous allocation triggers frequent garbage collection pauses, manifesting visually as dropped frames, stuttering, and general UI jank during the visualization.
📊 Impact: Reduces per-frame memory allocations to near-zero for the core lookup functionality. The node lookup is now purely O(1) reads without the O(N) write/allocation overhead per tick, keeping framerates consistently higher during active force-directed simulations.
🔬 Measurement: Verify by running the application locally (
npm run preview), navigating to/explore, and profiling the animation loop via Chrome DevTools Performance tab. You will observe a significant reduction in Minor GC (Scavenge) events while hovering and interacting with the graph compared to the baseline.PR created automatically by Jules for task 1732810029439257313 started by @servathadi