⚡ Bolt: [performance improvement] Optimize memory allocations in KnowledgeGraph - #196
servathadi wants to merge 1 commit into
Conversation
Moved `new Map()` instantiation out of the `requestAnimationFrame` loop in `KnowledgeGraph.tsx` to prevent per-frame memory allocation and garbage collection pauses. Node lookup map is now pre-computed in a `useEffect` and cached using `useRef`. Co-authored-by: servathadi <116760885+servathadi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
💡 What:
Moved the
new Map<string, GraphNode>()instantiation out of thesimulatefunction (which runs viarequestAnimationFrame) and into auseEffectwhere it is initialized only when dependencies change. The map is cached via auseRef(nodeMapRef).🎯 Why:
The
simulatefunction is a hot loop, running at 60 FPS. Allocating a newMapand populating it with nodes on every single frame causes significant memory allocation and triggers frequent garbage collection pauses, which degrades canvas animation smoothness.📊 Impact:
Eliminates hundreds of redundant object allocations per second during the animation loop, significantly reducing memory pressure and GC hiccups, resulting in a smoother user experience.
🔬 Measurement:
Use performance profiling in Chrome DevTools to observe the reduction in memory allocations and GC activity during the KnowledgeGraph animation. Visual verification via Playwright shows the graph still renders correctly.
PR created automatically by Jules for task 5178186946429108906 started by @servathadi